XSF Discussion - 2018-11-19


  1. Guus

    the Observatory appears to be misbehaving. PHP errors on the front page. Jonas', would you mind kicking off that frontend docker hub project, to see if it goes away?

  2. jonas’

    Guus, I can’t

  3. jonas’

    it needs manual iteam intervention, it’s not pulled automatically from docker hub

  4. Guus

    uhoh

  5. Guus

    ah

  6. jonas’

    I’ve tried to get iteam attention for weeks now about this :(

  7. jonas’

    but in my mind, I already figured that we need to re-implement this on top of something less awful to maintain

  8. Guus

    What we see now is not a relatively simple front-end issue?

  9. Guus

    where's the code anyway? Docker pulls from a non-existing github repo?

  10. Guus

    https://bitbucket.org/horazont/xmppoke-frontend <-- that one?

  11. Guus

    err, bitbucket, not github

  12. jonas’

    the xmppoke docker stuff itself on https://github.com/horazont/xmppoke-docker

  13. jonas’

    the frontend lives here: https://github.com/horazont/xmppoke-frontend-docker

  14. Guus

    yes, but line 14? https://github.com/horazont/xmppoke-frontend-docker/blob/master/Dockerfile#L14

  15. edhelas

    (I just posted the release note of Movim 0.14 on HN, for those that are interested https://news.ycombinator.com/item?id=18485822)

  16. jonas’

    Guus, ha, nice

  17. jonas’

    but why

  18. jonas’

    I don’t have mit bitbucket credentials at hand to check

  19. Guus

    bitbucket never agreed with me

  20. Guus

    hopefully you can find out what happened later

  21. jonas’

    Guus, I might forget, feel free to remind me later today (15:00Z+) or on wednesday

  22. Guus

    kk

  23. flow

    why not put a static page up on xmpp.net, saying that we are looking for help maintaining it

  24. Zash

    Sounds good

  25. daniel

    I'd volunteer to just rewrite it. But I think someone else is already doing so

  26. Kev

    It seems to be broken.

  27. Kev

    I restarted both poke and the frontend, and the frontend refuses to come up.

  28. Guus

    Kev, that's probably because the docker instance is being composed partly from a repository that's currently unvailable.

  29. Guus

    before the restart, the frontend gave a different error.

  30. Guus

    Daniel: what makes you think that someone else is already doing so/

  31. daniel

    Someone told me

  32. daniel

    😏

  33. daniel

    Holger mentioned that Matt the jabber.at admin is working on it and also sent me a link that I haven't had time to check out yet

  34. Kev

    Guus: It was just starting it, rather than recreating the image.

  35. Holger

    https://github.com/mathiasertl/xmpp-test

  36. Holger

    daniel: But in the meantime, he said "right now, it's more or less on ice".

  37. daniel

    If that doesn't lead anywhere I might start my own. I want a test that then will result in a simple boolean to integrate it into the compliance tester

  38. daniel

    And if I write the tooling to create the boolean I already have what it takes to generate a more verbose output

  39. Kev

    I suspect that the frontend can't cope with being restarted without being recreated, or something.

  40. Guus

    Daniel / Holger: Nice!

  41. Guus

    Kev: Odd!

  42. Guus

    Until a viable replacement is available, it's probably best not to give up on our old instance though

  43. Kev

    It seems like someone's moved things around on the filesystem and broken things, but I don't remember who set this up.

  44. daniel

    I think I might have to grow the compliance tester into a more general thing anyway. During the sprint I wrote a thing that tests for cors headers on the HTTP upload

  45. Guus

    might take a while before the replacement is ready. Looking at the effort that has gone into the old, but also the new tings (100+ commits) ...

  46. daniel

    At some point it will make sense to integrate tls testers

  47. Guus

    Kev, might've been me?

  48. Kev

    Let's see if I can at least fix the backup script before I go nuclear on it.

  49. Kev

    As things stand the backup script is broken, and the README is wrong.

  50. Kev

    (And the container won't start)

  51. Kev

    Well, at least I've got the backup script working again.

  52. Kev

    Oh, the creation scripts only work if the instance is running. If it's not running, they'll refuse to install a new one.

  53. Kev

    Got it back to Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/html/index.php on line 97 state, at least.

  54. Guus

    Thanks Kev

  55. jonas’

    daniel, who is rewriting it?

  56. jonas’

    the TLS tests can be easily based on testssl.sh, it has a JSON formatted output

  57. jonas’

    that was the plan when I get around to do it, but I didn’t start

  58. Guus

    jonas' : https://github.com/mathiasertl/xmpp-test

  59. Guus

    Jonas' this is your 15:01Z callback ping 🙂

  60. jonas’

    thanks!

  61. jonas’

    apparently I changed my username and bitbucket doesn’t do redirects :)

  62. moparisthebest

    jonas’: what I'm hearing is you broke it and it's all your fault

  63. jonas’

    no

  64. moparisthebest

    Lol <3

  65. jonas’

    Guus, fix for the URL is pushed

  66. Guus

    thanks jonas' !

  67. jonas’

    isn’t there a general race condition with multiple clients of the same account in a single MUC where when a MUC forwards a groupchat message to one of the clients and the client goes offline, it might get sent by the XMPP server to the other client ("most available resource")?

  68. Guus

    jonas' : both index.php as well as list.php don't handle a scenario well where the find_score query doesn't return rows. I'm assuming that's easily fixed. I'm unsure why no scores are returned though. To much work to be processed?

  69. jonas’

    I don’t know

  70. Guus

    https://bitbucket.org/jssfr/xmppoke-frontend/src/84b48437dca24deaf7557c982c069015cf09a396/index.php <-- line 89 does appear to validate if scores is non-empty, but line 97 does not

  71. jonas’

    I didn’t write the PHP code, and I don’t want to maintain it.

  72. Guus

    I'll have a stab at fixing the code to prevent the ugly php error

  73. Guus

    hargh, how do I fork in Bitbucket?

  74. Guus

    ah, by creating a new repo

  75. Guus

    oh, good, it uses mercurial.

  76. Guus gives up.

  77. jonas’

    not that hard when you just want to patch a thing

  78. jonas’

    hg clone, do your thing, hg commit file1 file2 ...

  79. Guus

    sure, but that'll make me install hg.

  80. Guus

    I'm doing things in the text editor of bitbucket

  81. Guus

    Jonas', I think I just created two PRs against your repo, that _should_ fix the issue

  82. jonas’

    Guus, can you try to try it for yourself?

  83. jonas’

    the frontend thing contains a docker-compose file which you should be able to use

  84. jonas’

    Guus, hm, I’m really not fond of maintaining this

  85. jonas’

    I don’t feel comfortable in reviewing PHP changes, and yet I’m now somewhat of a gatekeeper

  86. Guus

    I'm to stupid for docker

  87. Guus

    somehow, my changes aren't picked up

  88. jonas’

    did you re-build the image? with the correct tag?

  89. Guus

    probably not

  90. Guus

    ah, got it

  91. Guus

    jonas' : my commits fix php-related errors

  92. Guus

    likely not the underlying issue of the tests not being executed

  93. Guus

    but at least, it's failing more gracefully now.

  94. jonas’

    mmm

  95. MattJ

    jonas’ [15:20]: > isn’t there a general race condition with multiple clients of the same account in a single MUC where when a MUC forwards a groupchat message to one of the clients and the client goes offline, it might get sent by the XMPP server to the other client ("most available resource")?

  96. jonas’

    no, there isn’t, I figured it out by now

  97. jonas’

    due to: 8.5.3.2.1. Message For a message stanza of type "normal", "groupchat", or "headline", the server MUST either (a) silently ignore the stanza or (b) return an error stanza to the sender, which SHOULD be <service- unavailable/>.

  98. jonas’

    sorry for the noise

  99. MattJ

    Groupchat messages are not redirected to other resources

  100. MattJ

    Sorry, great :)

  101. Ge0rG

    Also "silently ignore the stanza"

  102. MattJ

    Silently ignore that option

  103. Ge0rG

    Implementation defined behavior.

  104. jonas’

    IB!

  105. jonas’

    at least not UB!

  106. MattJ

    Silently ignore buggy implementations

  107. Ge0rG

    MattJ: they are not buggy if they are compliant

  108. MattJ

    You think so? :)

  109. Ge0rG

    MattJ: by your definition, mod_carbons and mod_mam are buggy as well

  110. Ge0rG shortly considered writing "as hell"

  111. MattJ

    They are

  112. Ge0rG

    And the XEPs are buggy too. And the RFC.

  113. MattJ

    TCP/IP is buggy, but (mostly) follows spec

  114. MattJ

    Abandon hope

  115. Zash

    Humans are buggy

  116. jonas’

    it’s all buggy

  117. MattJ

    Not all

  118. MattJ

    The stuff we haven't written yet is perfect

  119. Ge0rG

    It's buggy all the way down. A fractal of bad protocol design

  120. MattJ

    Ge0rG: great name for a client!

  121. Ge0rG

    MattJ: "Buggy"? 😀

  122. moparisthebest

    Maybe you should just start from scratch, call it matrix or something

  123. Zash

    Bug is a kind of dance?

  124. moparisthebest

    I'm sure you won't hit the same problems :)

  125. Ge0rG

    > have you tried the Buggy messenger? All of them!

  126. Zash

    -y as suffix is hip again?

  127. Zash

    hippy

  128. Ge0rG

    Buggy, the zimpy messenger.

  129. Ge0rG

    My phone auto corrected zimpy to "gimpy"

  130. lovetox

    when was the last XEP that made it to DRAFT, just out of interest?

  131. jonas’

    commit c58d3bbf5ed18e95b374e3bc1db9a85de40f2661 Author: Jonas Wielicki <j.wielicki@sotecware.net> Date: Thu Jan 25 08:54:39 2018 +0100 XEP-0387: Move to draft

  132. jonas’

    that’s a good candidate

  133. Zash

    1806, it was a cold winter that year

  134. jonas’

    ha, the compliance suites

  135. lovetox

    lol :D

  136. lovetox

    ok and now a real xep

  137. lovetox

    please

  138. Zash

    must have been in the dark ages

  139. jonas’

    I’d h ave to do more magic than that, but it might be May 2017

  140. jonas’

    or March?

  141. jonas’

    march

  142. jonas’

    back when Sam was still editoring much -- it’s not my fault, I swear!!

  143. Ge0rG

    Getting compliance Suite into draft was hard enough!

  144. jonas’

    yes, XEP-0233 was the last one moving to draft before that, that was in Mar 2017

  145. SamWhited

    Speaking of compliance suites, someone should do some for this upcoming year (even if they're basically the same) so that they don't appear out of date

  146. jonas’

    yeah, I’ve got that on my todo

  147. Ge0rG

    If it's the same, can we just update the year?

  148. jonas’

    next council will decide

  149. jonas’

    (but I’m in favour)

  150. Ge0rG

    I think I was missing one XEP when explaining what's relevant for mobile to haeckse last weekend

  151. Ge0rG

    Oh yes, it's missing 0184

  152. Ge0rG

    I don't even understand how we could miss that.