XMPP Council - 2023-03-22

  1. bsqjxd has left

  2. emus has left

  3. emus has joined

  4. neox has left

  5. neox has joined

  6. Wojtek has left

  7. neox has left

  8. moparisthebest has left

  9. moparisthebest has joined

  10. diyar has joined

  11. diyar has left

  12. bsqjxd has joined

  13. marc0s has left

  14. marc0s has joined

  15. bsqjxd has left

  16. Tobias has left

  17. Tobias has joined

  18. MSavoritias (fae,ve) has joined

  19. neox has joined

  20. gooya has joined

  21. sonny has left

  22. bsqjxd has joined

  23. sonny has joined

  24. vaulor has left

  25. vaulor has joined

  26. sonny has left

  27. sonny has joined

  28. vaulor has left

  29. vaulor has joined

  30. Katherine has joined

  31. sonny has left

  32. sonny has joined

  33. Katherine has left

  34. bsqjxd has left

  35. bsqjxd has joined

  36. Kev has joined

  37. sonny has left

  38. sonny has joined

  39. sonny has left

  40. sonny has joined

  41. vaulor has left

  42. vaulor has joined

  43. Wojtek has joined

  44. sonny has left

  45. sonny has joined

  46. Wojtek has left

  47. sonny has left

  48. gooya has left

  49. sonny has joined

  50. pep.

    In the end I reused the same PR (unintentionally, I just pushed to the same branch..). I'm happy for council to delay to next week. Especially since MattJ had some more stuff to add?

  51. MattJ

    I might figure out a sentence or two about pubsub#itemreply

  52. pep.


  53. pep.

    I tried to split commits to make the review slightly easier. I id change existing normative text with my publish_node_full change so ~~. Also feedback on language / words / style etc. is welcome

  54. Wojtek has joined

  55. gooya has joined

  56. sonny has left

  57. sonny has joined

  58. MattJ

    I put a PR in your PR: https://github.com/Ppjet6/xeps/pull/1

  59. MattJ

    Reviewing your changes, everything looks good, except it feels a little confusing when it says: "the service MUST delete one of the existing items"

  60. MattJ

    This MUST is not conditional on the value pubsub#publish_node_full, but it's obviously intended to be

  61. MattJ

    Hmm, I think the simplest fix may be to simply append "or reject the new item." - all the cases are explained in the following text, so it should be clear enough

  62. MattJ

    I'll add it to my PR

  63. pep.

    hmm you aven't included it yet right? I merged the PR and I read the end of your messages right after :/

  64. pep.

    I can change that myself, let me find the place

  65. pep.

    Ah right

  66. pep.

    I guess I didn't want to change the original sentence too much so that the normative parts don't change, but..

  67. pep.

    A pubsub service still needs to do all of the original text even though it doesn't implement publish-node-full

  68. pep.

    "and the maximum is reached when an item is published" this looked slightly confusing to me, but that's the original wording and it seems people understood it ok? So I'm not gonna change it

  69. MattJ

    Ah, I just committed https://github.com/Ppjet6/xeps/commit/905c18f4f2384394dab181c6ac1a406653ef55e7

  70. MattJ

    Okay, I hadn't really thought about the existing text

  71. MattJ

    It contradicts itself? :P

  72. MattJ

    One section says "the service MUST delete one of the existing items" and the other says "the service MUST return a &conflict; error"

  73. MattJ

    Sorry, I didn't realise this inconsistency was already there

  74. bsqjxd has left

  75. bsqjxd has joined

  76. MattJ

    Ah no, that is indeed new text

  77. pep.

    Ah sorry I just pushed something, I hadn't noticed activity in this rom :x

  78. pep.

    Ah sorry I just pushed something, I hadn't noticed activity in this room :x

  79. pep.

    (many unread rooms)

  80. pep.

    Well.. the "MUST return a &conflict; error" is only if the option is set to "reject"

  81. pep.

    let me try to pull your changes nonetheless

  82. MattJ

    Yeah, I adjusted the order of clauses in that commit I just linked, to make that clearer (just in case...)

  83. pep.

    How did you link to a commit on my repo I haven't merged?

  84. MattJ

    Github works in mysterious ways

  85. pep.

    https://github.com/mwild1/xeps/commit/905c18f4f2384394dab181c6ac1a406653ef55e7 better.

  86. MattJ

    Now I just regret writing "any of the following values" instead of "one of the following values" (but I don't want to make merging harder)

  87. pep.

    I may be able to edit that, it's fine

  88. bsqjxd has left

  89. bsqjxd has joined

  90. pep.

    Ok I've pushed our changes

  91. vaulor has left

  92. jonas’

    o/ due to lack of an agenda and facing conflicting private appointments, I decided to prioritise the latter and will likely not be available unless the meeting runs for >20mins

  93. jonas’

    sorry for the short notice

  94. vaulor has joined

  95. sonny has left

  96. sonny has joined

  97. daniel

    no worries. I was just going to encourage everyone to catch up with https://mail.jabber.org/pipermail/standards/2023-March/039215.html and the corresponding PR (so we can vote on it next week) and pretty much leave it at that

  98. moparisthebest

    Yep will do

  99. MSavoritias (fae,ve) has left

  100. MSavoritias (fae,ve) has joined

  101. bsqjxd has left

  102. bsqjxd has joined

  103. sonny has left

  104. sonny has joined

  105. vanitasvitae_ has left

  106. vanitasvitae_ has joined

  107. emus has left

  108. emus has joined

  109. moparisthebest has left

  110. Syndace has left

  111. Syndace has joined

  112. moparisthebest has joined

  113. sonny has left

  114. sonny has joined

  115. Wojtek has left

  116. MSavoritias (fae,ve) has left

  117. moparisthebest has left

  118. moparisthebest has joined

  119. Wojtek has joined

  120. Tobias has left

  121. Tobias has joined

  122. Tobias has left

  123. Tobias has joined

  124. neox has left

  125. emus has left

  126. Kev has left

  127. SouL has left

  128. kusoneko has left

  129. kusoneko has joined

  130. gooya has left

  131. gooya has joined

  132. bsqjxd has left

  133. bsqjxd has joined