XSF Editor Team - 2017-01-18

SamWhited: Shall we simply tell peter waher to submit the changes via mail?

Did I miss context?

Kev: see standards@

Nothing's jumping out at me there as being from Peter Waher.

What's the rough timestamp?

https://mail.jabber.org/pipermail/standards/2017-January/031966.html

Oh, last few minutes. Spam trap then, mabye. Thanks.

I'd be inclined to reply "Submitting Git patches via email is allowable, as it's always been, as long as they're appropriately split" :)

Kev: patches and/or full xeps?

as in "the full xep of a new version of an existing xep"

Oh, that's ugly as sin.

Is it?

But as long as he's not screwing around with formatting and stuff, I guess that's fine.

does it matter if we apply a patch or simply copy the submited file over the existing?

I mean yes of course, patches would be better

It dosn't, really.

I can't type this morning :(

I replied.

It was caught in the spamtrap.

Hmm… that had nothing to do with having several commits in a single file, his diff was just so convoluted it was hard to review.

Oh well, if he sends smaller patches or someone else is willing to do it I guess it will be fine.

If his explanation of the reason wasn't really the reason, you should reply saying so :)

Yah, I'll reply when I get to the office

Thanks. I'm trying to find the PR now.

I should probably not have taken his explanation at face value, sorry.

Kev: SamWhited: So we *do* reject submissions with a lot of non-changes (whitespace only, etc)?

Oh, if someone submits a stupid patch, we'd reject it, sure.

I'm not sure if whitespace counts, but certainly if it did other stupid things.

It also had a ton or git weirdness that I didn't want to unwind, IIRC, but you can see for yourself, maybe someone else will be okay dealing with it

I'm still trying to find the PR.

Guess it's a thin line what to accept.

Kev involved:PeterWaher

That gives results for you?

It doesn't seem to for me, just two entries is source files.

involves:PeterWaher

https://github.com/xsf/xeps/pull/169

Ah, ta.

Oh, he wasn't kidding.

He really can't use Git.

and we shouldn't require git for xep submission

Maybe the best thing to do is just suggest that if he works with any developers to ask one of them to help.

that PR doesn't look to bad to me

the only strange thing appears to be the merge commit at the ned

The merge commit looks weird. Other than that, it doesn't look too bad to me.

Although all the dates need fixing, at least.

Ah yah, that's not too aweful. Maybe it was more the size of the thing

I think in this case just cleaning it up and submitting might be best. I'm not convinced that whatever he does next is going to be any easer for us to deal with.