-
pep.
jonas’, please do tell me when you've got time to spare. I can probably adapt more easily. I'll be at a conference sunday to tuesday, wednesday I should be in dresden (from the afternoon). I'm still considering going to Berlin for the weekend, 19-22 (There's All Systems Go!), and after that I'm back to Dresden for a few days. until the 24th maybe. I'll be back maybe a week after that :P
-
pep.
We obviously don't have to do that IRL, online is perfectly fine. Dresden is just going be a place I've got time to do stuff :P
-
pep.
(I mean nothing planned in particular. I obviously have lots of bugs to fix in different projects)
-
pep.
https://github.com/xsf/xmpp.org/pull/599 this should have been accepted a while back :P
-
pep.
I suggest you reupdated it(?) < jonas’
-
pep.
I can't review it btw
-
jonas’
whoops
-
pep.
reupdate*
-
jonas’
thanks
-
pep.
Also the strophe update seems legit
-
jonas’
this is the wrong venue by the way
-
pep.
editor@ ?
-
jonas’
yes
-
pep.
That's not editor stuff?
-
jonas’
no
-
pep.
ok
-
jonas’
the website has nothing to do with the editor
-
pep.
oh
-
pep.
Is there a venue for that even
-
jonas’
xsf@
-
pep.
ok, sure
-
jonas’
pep., did you check out this one already? https://github.com/xsf/xeps/#gardening-issue-triaging-by-non-editors
-
pep.
nope, thanks
-
jonas’
that’s a good way to get your hands dirty
-
jonas’
for the last bullet point, always assign me
-
jonas’
there is no other editor at the moment :)
-
jonas’
(or, assign yourself and get your hands dirty with that ;))
-
jonas’
in more detail: https://github.com/xsf/xeps/#triaging-a-pr
-
pep.
I don't know you but I generally don't like having issues assigned randomly (by an outsider), especially in a team. It's certainly easier when it's a team of 1 :P
-
pep.
At least at work, I didn't like it
-
jonas’
pep., having anyone assigned is a good sign for "this has been completely triaged"
-
jonas’
we may change the procedure if you’re not fine with it, but for me it’s OK
-
pep.
I see
-
pep.
nah, if it has proper meaning associated to it it's fine. That sounds good
-
pep.
I don't like it when it's "hey you, deal with it" :)
-
jonas’
I’ll do some minor cleanup to the triaging section
-
jonas’
pep., https://github.com/horazont/xeps/tree/feature/readme-triage-update#triaging-a-pr
-
pep.
Thanks, I didn't mean to rush you
-
jonas’
oh, this was more like the "uh, this is wrong I need to fix it now" thing :)
-
pep.
heh
-
pep.
"Does the PR add a revision block? If no, add the Needs Version Block label." is that always necessary now?
-
jonas’
yes
-
pep.
ok
-
jonas’
updated it once more
-
pep.
You forgot 2. in 1. Sanity Checks ?
-
jonas’
no, moved it elsewhere
-
pep.
Ah, markdown doesn't care about numbering I see
-
jonas’
yeah
-
pep.
Just that they are numbers
-
pep.
It doesn't even check that they're increasing numbers :x
-
jonas’
cleaned that up
-
pep.
"2. If the PR does not a revision block" *add
-
pep.
/contain
-
jonas’
thanks, fixed
-
pep.
Same error below, in 5., sorry
-
jonas’
should be fixed there too
-
jonas’
did a s/// for that one :)
-
pep.
k
-
pep.
looks good otherwise
-
jonas’
thanks
-
jonas’
hitting the green button
-
jonas’
that should get you started until I can make time :)
-
jonas’
I have vacation starting tomorrow, that should help
-
pep.
k