XSF Editor Team - 2019-10-15

  1. pep.

    hmm, how do I push on georg's branch btw, on github

  2. pep.

    Is that possible?

  3. pep.

    jonas’, ^

  4. pep.

    How do you usually do? Do you just prepare the merge on your repo and only then push to master?

  5. pep.

    note for later: I'll want to add support to send-updates.py to use my local msmtp setup

  6. pep.

    heh the XEP- headers are a nice touch

  7. jonas’

    pep., I think there are instructions for that on the PR page

  8. jonas’

    pep., and yes, normally I prepare just loclly

  9. pep.

    Right, it doesn't talk about what I want to do, it's another workflow, ok

  10. pep.

    unrelated, pilotfiber.dl.sourceforge.net has an expired cert since Sep 22 apparently.. it's being pulled in xep-docker-base

  11. pep.


  12. jonas’

    I have a fix for that in the pipeline

  13. pep.


  14. jonas’

    for now, just use the latest build off docker hub

  15. pep.

    https://github.com/xsf/xeps/pull/843 should I also put that in the batch or wait a bit?

  16. pep.

    https://github.com/Ppjet6/xeps/tree/merge-xep-423%2C402%2C405 jonas’

  17. pep.


  18. pep.

    I've been rebasing stuff. Maybe I should force the author not to be me to have that a bit cleaner

  19. pep.

    Or I can just merge

  20. jonas’

    don’t rebase other peoples commits

  21. jonas’

    that’ll confuse github

  22. pep.

    yeah I can see that..

  23. jonas’

    $ cat ~/.local/bin/git-make-pr-branch #!/bin/bash set -euo pipefail branch_name="$1" remote="$2" pr="$3" commit_id="$(git ls-remote "$remote" "refs/pull/$pr/head" | cut -f1)" git fetch "$remote" "$commit_id" git checkout -b "$branch_name" "$commit_id"

  24. jonas’

    that script will make a new branch with the HEAD of the PR

  25. jonas’

    you can add commits there, and then do a merge to master

  26. pep.

    I know, I'm already doing that

  27. pep.

    Ok, so merge

  28. jonas’

    yes, merge

  29. jonas’

    XEP-0423 lacks a revision block in the tree you linked me

  30. pep.

    wait I did add one though

  31. pep.


  32. jonas’

    you can add https://github.com/xsf/xeps/pull/843 to the merge

  33. jonas’

    pep., that’s not showing up in https://github.com/xsf/xeps/compare/master...Ppjet6:merge-xep-423,402,405?expand=1 for some reason

  34. pep.

    it is

  35. jonas’


  36. pep.

    Only under my name

  37. jonas’

    I’m too stupid to read diffs

  38. pep.


  39. jonas’

    did you check that the CI passes on this?

  40. pep.

    I have an awfully slow connection atm, docker barfs on me at each attempt

  41. pep.

    I get disconnected on a regular basis

  42. jonas’

    pep., the CI is run by github, too

  43. jonas’

    just make a PR

  44. pep.

    Right. let me do merges then, and I'll submit a PR

  45. jonas’


  46. jonas’

    other than that, the formal stuff looks ok

  47. pep.

    Sent, https://github.com/xsf/xeps/pull/844

  48. pep.

    I'm moving to c3d2, see you online in a bit :)

  49. jonas’

    oh, that’s close

  50. pep.

    Yes it's not far from you :p

  51. pep.

    I'm here until thursday morning, then moving to munich

  52. pep.

    daniel should be there tonight, and Astro, don't know if you know him

  53. jonas’

    yeah, met astro at some meetpu

  54. pep.


  55. pep.

    Ok PR passed. I'll merge and spam standards

  56. jonas’

    sounds good

  57. pep.

    smtplib.SMTPSenderRefused: (452, b'4.3.1 Insufficient system storage', 'pep@bouah.net')

  58. pep.

    oops, thanks smtplib for reminding me

  59. pep.

    hmm, that didn't catch 335?

  60. jonas’

    because 335 doesn’t have a revision block, and the transition isn’t handled specially

  61. jonas’

    please use the dry run mode to double-check output before sending emails

  62. jonas’

    it’s fine to not-announce the transition tho

  63. jonas’

    (we never did that before, either)

  64. pep.


  65. pep.

    Yeah I did check emails before. The one for 423 is a bit mangled but ~

  66. pep.

    I mean the revision block

  67. jonas’


  68. pep.

    I'm also waiting for dwd to send an email or sth to standards for the agenda for tomorrow, to add 292 which is stuck in LC

  69. pep.

    But I guess it's probably not happening at this point (the email)

  70. jonas’

    yeah, dwd sent a mail to council@

  71. jonas’

    he won’t be able to write an agenda before tomorrow morning

  72. jonas’

    he won’t be able to write an agenda before tomorrow noon

  73. jonas’

    you can send agenda suggestions to dave@cridland.net

  74. pep.

    is council@ private?

  75. pep.

    Or am I just not subscribed to it

  76. pep.

    ok it's not private

  77. pep.

    I have a reliable connection now! I can check your docker PR

  78. jonas’

    pep., https://github.com/xsf/xep-docker-base/pull/4

  79. pep.

    heh, ok

  80. pep.

    I'm curious how much work this is going to be to update to buster tbh..

  81. jonas’

    I have another PR ;)

  82. jonas’

    oh I don’t

  83. jonas’


  84. pep.


  85. pep.

    jonas’, https://github.com/xsf/xeps/pull/810 that's ready to merge right?

  86. pep.

    I can take it as well if you want

  87. jonas’

    doesn’t kev have to ack that first?

  88. pep.

    Ah indeed

  89. pep.

    https://github.com/xsf/xeps/pull/819 this is editor land though right?

  90. pep.

    Ah I tagged it already

  91. pep.

    "update copyright year"

  92. flow

    pep., btw https://github.com/xsf/xeps/pull/825 is "ready to merge", I didn't put up the label because I'm OP

  93. flow

    in case you want to have something to test your workflow with

  94. pep.

    I was looking for an ACK from Lance but yeah you have that in there

  95. pep.

    jonas’, I'm wondering if we shouldn't stop assigning editors(?) I personally don't mind if you merge stuff I have reviewed, and I guess in time it should be reciprocal :p

  96. pep.

    Maybe we want a "please don't touch this, I'll do it" signal

  97. pep.

    And that should be assigning?

  98. pep.

    And that could be assigning?