XSF Editor Team - 2020-01-22

  1. flow

    "Authors: Lance Stout , JC Brand" why is there an extra space before the comma?

  2. jonas’

    URL?

  3. jonas’

    probably XSL bug

  4. flow

    jonas’, i think it's a css bug

  5. jonas’

    maybe

  6. jonas’

    URL?

  7. flow

    affecting all the xeps

  8. jonas’

    I don’t want to go through all the XEPs to find one with >1 author, please

  9. jonas’

    you seem to know at least one affected

  10. flow

    jonas’, I think you can select a random xep with multiple authors

  11. jonas’

    aaaaaaaaaaaaaaaaa

  12. flow

    waaaaaaaaaa

  13. jonas’

    I don’t know a single XEP off the top of my head with >1 author

  14. jonas’

    and it’s not visbile in the extension list

  15. flow

    424

  16. jonas’

    thanks

  17. jonas’

    XSL bug

  18. jonas’

    thanks, looking into it

  19. flow

    doesn't the xsl just build an html list?

  20. jonas’

    yes

  21. jonas’

    it adds spaces between the <li/> tho

  22. jonas’

    cause bug

  23. flow

    curious to see the fix, as I only see the space introduced between firstname and surname in the xsl

  24. jonas’

    yeah

  25. jonas’

    not quite sure yet where it comes from

  26. jonas’

    (to be clear: the "space" is the newline between the <li/> element?) ✎

  27. jonas’

    (to be clear: the "space" is the newline between the <li/> elements) ✏

  28. jonas’

    eh, also, we’re claiming XHTML, but writing HTML :/

  29. pep.

    :(((

  30. jonas’

    but that’s a different hill to work on

  31. pep.

    sure

  32. jonas’

    I blame the xsltproc html writer

  33. pep.

    We're probably not serving the correct mime type though right? Otherwise we'd be seeing xml errors?

  34. jonas’

    we’re not serving any Content-Type header

  35. jonas’

    ah, we are

  36. jonas’ slaps firefox

  37. jonas’

    it’s of course text/html

  38. pep.

    :x

  39. pep.

    Ok so we're "not" doing xhtml :)

  40. flow

    like everybody else ;)

  41. jonas’

    flow, except that we claim XHTML in the doctype

  42. flow

    pfff, doctype…

  43. flow

    do browsers even look at this?

  44. flow

    but yes, should definelty be fixed either way

  45. jonas’

    going to fix both

  46. pep.

    I used to do <!DOCTYPE html><html xml:lang="en">..</html> declared as application/xhtml+xml

  47. pep.

    on a previous static website

  48. Link Mauve

    pep., with this doctype you can use either MIME types.

  49. pep.

    sure

  50. pep.

    I like when my browser tells me what I'm doing wrong :x

  51. pep.

    Instead of trying to interpret stuff randomly

  52. Link Mauve

    Same, I use the same Content-Type as yours wherever I can.

  53. jonas’

    so the fix is to set indent='no' on xsl:output

  54. pep.

    it's been ages I haven't done xslt.. I should have a look again someday

  55. jonas’

    flow, https://github.com/xsf/xeps/pull/885 (cc @ pep.)

  56. pep.

    do you have a rendered version of a xep? /me pulls the change

  57. jonas’

    yeah sure, one sec

  58. pep.

    nvm

  59. pep.

    I'll do that locally so I can diff

  60. jonas’

    https://sotecware.net/files/xeps/xep-0424.html

  61. jonas’

    the diff won’t be pretty

  62. jonas’

    like, seriously not pretty

  63. jonas’

    due to indent='no'

  64. pep.

    I'm curious if the `indent='no'`is going to change much

  65. pep.

    right

  66. jonas’

    yes

  67. jonas’

    it removes all the linebreaks

  68. pep.

    yeah diff is a bit useless :x

  69. pep.

    I guess we'll see if that affects anything else?

  70. jonas’

    yupp

  71. pep.

    LGTM otherwise

  72. jonas’

    I’m going to put the html doctype on its own line tho

  73. jonas’

    updated the PR

  74. pep.

    ok

  75. pep.

    sure

  76. jonas’

    merged

  77. pep.

    Hmm, it does need to be on its own line no?

  78. pep.

    Just curious

  79. jonas’

    I think it does

  80. pep.

    k

  81. flow

    jonas’, thanks for the attribution :)

  82. jonas’

    thanks for finding it

  83. flow

    jonas’, and respect for finding *that* fix.

  84. jonas’

    so, it was clear that this was the newline between the <li/> elements being interpreted as whitespace as per HTML

  85. jonas’

    I’ve got some experience with messing with HTML ;)

  86. jonas’

    then it was just a question of how to make XSLT not emit that newline

  87. flow

    yep, if you do not know or think about '\n' being transformed to ' ', then you are probably lost on this one

  88. pep.

    flow, I would think that's one of the first thing you learn when doing html :x

  89. pep.

    also xml:space !

  90. flow

    pep., the time where I did html is more than a decade ago, so I either never know or forgot about it

  91. flow

    pep., xml:space?

  92. pep.

    hmm, I might be mistaken but isn't that related?

  93. pep.

    Or it's just a rule of html?

  94. flow

    dunno

  95. pep.

    https://www.w3.org/TR/REC-xml/#sec-white-space

  96. pep.

    using 'default' and not preserve

  97. pep.

    I'd like that xmpp use that explicitely :x

  98. flow

    do we? I assume whitespace to be preserved e.g. in </body>, or is this other whitespace?

  99. pep.

    Maybe it's declared in the RFCs, but I don't think I've seen any mention of that in XEPs

  100. Link Mauve

    jonas’, in HTML5, you don’t use <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> anymore but <meta charset="utf-8"/>

  101. jonas’

    Link Mauve, true!

  102. jonas’

    make a PR, while you’re at it

  103. jonas’

    ? :)

  104. Link Mauve

    I have to send a letter to my UK bank, that’ll be a very good procrastination object!

  105. pep.

    nooo

  106. pep.

    so close yet so far

  107. Link Mauve

    jonas’, I… can’t find this element in the XSLT stylesheet.

  108. jonas’

    I’m scared that xsl:output generates it

  109. Link Mauve

    Me too.

  110. jonas’

    oh dear

  111. jonas’

    Link Mauve, try without encoding=''

  112. jonas’

    though I’d be hesitant to remove that again

  113. jonas’

    otherwise we have to sed it

  114. pep.

    ugh

  115. jonas’

    :D

  116. Link Mauve

    And add a normal <meta/> node?

  117. jonas’

    maybe

  118. Link Mauve

    While you’re at it, maybe merge #669. ✎

  119. Link Mauve

    While you’re at it, maybe merge https://github.com/xsf/xmpp.org/pull/669 ✏

  120. jonas’

    I don’t have +w there anymore

  121. Link Mauve

    Ah.

  122. jonas’

    otherwise I would’ve

  123. pep.

    I do, but I don't think I should (just because I'm board)

  124. Link Mauve

    That doesn’t sound like a thing that is wanted.

  125. pep.

    merged. xsf/xmpp.org stuff belongs to commteam now though

  126. Link Mauve

    Also, meh, #879 didn’t reach Council.

  127. Link Mauve

    Despite it being quite trivial.

  128. jonas’

    Link Mauve, it did

  129. jonas’

    everyone voted +1 on it

  130. jonas’

    I’m not sure why you think it didn’t, because it was both on the agenda and discussed in the meeting

  131. Link Mauve

    Ah, it wasn’t in the minutes.

  132. jonas’

    there haven’t been any minutes sent yet?

  133. jonas’

    those are from last week

  134. Link Mauve

    Oh, it was for last week.

  135. Link Mauve

    Nvm then. :)