-
jonas’
clearing the editor queue
-
pep.
Thanks
-
pep.
Sorry I'm not really active lately :x
-
jonas’
it’s ok
-
jonas’
I have this scheduled window now, which is fine
-
pep.
Yeah but still. It doesn't have to be only you :)
-
jonas’
all volunteers
-
jonas’
hm
-
jonas’
should change of status Draft -> Deprecated cause a version bump, and if it should, in which digit?
-
pep.
hmm.
-
jonas’
going with a major version bump, akin to moving to Final
-
pep.
I guess
-
pep.
Which one is that again
-
pep.
Ah the CS
-
jonas’
yeah
-
jonas’
https://github.com/xsf/xeps/pull/886 Editorial Change && Needs Version Block => Ready to Merge
-
jonas’
otherwise I may overlook it
-
jonas’
cc @ pep. ^
-
pep.
k
-
pep.
Well Needs Version Block is not ready to merge :p
-
jonas’
false
-
jonas’
version block is added by the editor
-
jonas’
ready to merge is defined as "no acknowledgements needed"
-
jonas’
> No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.
-
pep.
Ah, ok then we had diverging definitions :)
-
jonas’
the definition is right below the label name ;)
-
pep.
I didn't even know there were descriptions for these
-
jonas’
there are more! https://github.com/xsf/xeps/labels
-
jonas’
:)
-
jonas’
I put some time into writing them some time ago
-
pep.
Yeah.. I never go there
-
jonas’
to streamline things
-
jonas’
they’re also shown in the dropdown below the names tho
-
pep.
k, well I just type part of the name and <Enter> :x
-
jonas’
at least here, maybe that’s just me?
-
Kev
No, not a major version bump, because that explicitly means it's become Final.
-
jonas’
https://sotecware.net/images/dont-puush-me/4_DzEj_Ne-G9gUBEITmBdizpYSV746Rih5g8IUaKVk4.png
-
jonas’
Kev, aaaagh, I hate our versioning!
-
jonas’
I truly hate it
-
jonas’
it drives me crazy
- jonas’ goes back to roll back things
-
Kev
Oh, sorry. I didn't mean to be too late.
-
jonas’
sure, not your fault
-
jonas’
the weird versioning is at fault
-
jonas’
either way: what’s the right way then?
-
Kev
I don't know what we've done in the past for this, I'm afraid, but I do remember fairly clearly that bumping major version only happens -> Draft -> Final.
-
Kev
Let's see if Xep1 can help.
-
Kev
Right, XEP-0001 is at least clear that things only become 2.0 if they go Final.
-
Kev
That's something, I guess...
-
jonas’
for certain definitions of "clear" ;)
-
jonas’
I’ll go with a minor bump then.
-
Kev
Could just do editorial?
-
Kev
On account of there being no change in content?
-
jonas’
Kev, I would like to ensure that any notifiable event (i.e. which warrants an email) is at least a minor bump
-
Kev
And if it transpires that it needs to be a minor bump instead, it's much easier to add a bigger bump than it is to undo one?
-
jonas’
I won’t be sending mails for purely editorial changes in the future, and I’ll automate that distinction using the version number.
-
jonas’
(though, granted, this could also be detected by the change of state)
-
jonas’
so you’re right
-
jonas’
let’s do this on the patch level…
-
jonas’
Kev, thanks for chiming in before I hit the green button :)
-
Kev
Sorry for being a dissenting voice (although I do think it's the right thing to do here).
-
Kev
I haven't found anything in XEP1 yet that helps hint what to do, only what not to do, FWIW>✎ -
Kev
I haven't found anything in XEP1 yet that helps hint what to do, only what not to do, FWIW. ✏
-
Kev
The last thing to be deprecated was https://xmpp.org/extensions/xep-0137.html in 2018, when Sam used a minor version bump, FWIW.
-
Kev
Prior to that 2017 https://xmpp.org/extensions/xep-0136.html when Sam also used minor. Before that https://xmpp.org/extensions/xep-0130.html in 2012, when Peter did a minor bump.
-
Kev
So if you want to do a minor bump there's certainly plenty of precedent.
-
Kev
(Oh, my ordering is stupid, those aren't the three most recent, but the point probably stands)
-
jonas’
I’m going with patch level now
-
jonas’
the tooling can deal with that, I was just confused
-
Kev
Anything other than major is probably fine :)