XSF Editor Team - 2020-11-01

https://github.com/xsf/xeps/pull/996/ should be splitted as it touches several XEPs and revision blocks should be added right?

Also does https://github.com/xsf/xeps/blob/master/docs/TRIAGING.md No 5 apply to all XEPs not being ProtoXEPs and not in experimental state? So also for deferred XEPs?

mdosch, #996 touches a bunch of related XEPs and it may be purely editorial

in which case it might be OK to not split it, but it does need the [Needs Version Block] label ✏

mdosch, good catch w.r.t. Deferred; if you have the time, please make a PR against TRIAGING.md to fix that. Deferred should be treated the same as Experimental, except that a note needs to be added for the Processing Editor to remind them of de-Defer the XEP if the changes are non-Editorial

Version not revision block label?

Ah I see. Thanks :)

the label is called Needs Version Block

there is no Needs Revision Block label

Yes, I saw just after I asked. :D

Another thing: For the "flow chart" in 3 ii and iii should have an stop added and should be moved before i. Otherwise you'd add the label ready to merge prior to checking for the version block.

that is OK

or maybe not, the order could be flipped

Ready to Merge and Needs Version Block are not mutually exclusive

Ready to Merge just means that the author does not need to do anything and that all approvals have been collected

Wouldn't you wait for the change before merging?

only if you let the author do it

Ah ok.

Needs Version Block is mainly an instruction for the Processing Editor, not for the author

De-deferr means changing the state to experimental?

yes

Thanks

Damn.

I wanted to push it to my fork and PR but I accidentally pushed directly to the repo. :(

https://github.com/xsf/xeps/commit/55a8b66e21a681170c7c77c76c48c6e3cb88ca19

looking at it

https://github.com/xsf/xeps/commit/55a8b66e21a681170c7c77c76c48c6e3cb88ca19#r43771271 otherwise LGTM

https://github.com/xsf/xeps/commit/55a8b66e21a681170c7c77c76c48c6e3cb88ca19#r43771332

Just remove it?

So, this time I made it properly as a PR: https://github.com/xsf/xeps/pull/997

Maybe move the `If the XEP is in Deferred state` item one step up, then the Otherwise is still correct.

Done

mdosch, something is off with the email address you’re using in the commits, please make sure it’s associated with your github account

Added it to the github account.

perfect, thanks

no worries :)

it’s my choice to act on these messages :)