-
tmolitor
jonas’ what is missing before this can be merged? https://github.com/xsf/xeps/pull/1128
-
jonas’
tmolitor, thanks for asking
-
jonas’
https://github.com/xsf/xeps/pull/1142 and #1128 look very similar
-
jonas’
so it's not clear to me what to do here
-
tmolitor
1142 contains one more commit not in 1128, it is intended to bemerged on top ov 1128
-
jonas’
ah
-
jonas’
please mark 1142 as draft until 1128 is merged
-
tmolitor
okay, I'll do
-
jonas’
in addition, 1128 commit history needs cleaning up: it adds a revision block, but not in the recentmost commit.
-
jonas’
when adding a revision block, it must be added in the recentmost commit, otherwise it is ambiguous what the revision really contains
-
tmolitor
okay, I'll do
-
tmolitor
I can squash all commits into one if that is okay
-
jonas’
I suppose in this case that's okay
-
tmolitor
okay
-
tmolitor
done
-
tmolitor
I rebased both other PRs upon thesquashed one now
-
jonas’
tmolitor, LGTM now, I'll take care of it next tuesday
-
jonas’
(unless you have constraints which raise the urgency)
-
tmolitor
No, no constraints other than the one that this change is waiting to geht merged for a couple of weeks now ;)
-
tmolitor
jonas’: -^
-
jonas’
right, tuesday it is :)
-
tmolitor
perfect :)