XSF Editor Team - 2022-12-21

what would it simplify if we do not use commit notifications?

(I'm still not convinced those wouldn't be a significant step down from the current emails)

merging a PR can trigger any emails in whatever format desired, and you don't have to bother with verifying things happen in the same commit in a list of any commits which may include merge commits, just in 1 commit, because you are only ever dealing with 1 commit

basically all the issues now that start with "go through a list of commits..." can just be applied per PR, which seems to vastly simplify the entire thing, no? and I think the only thing it breaks is you can't have 1 PR publish multiple versions of a XEP, which seems good actually?

Sorry now I have to go to sleep, damn timezones :)

good night :)

the 1 commit vs. list of commit thing doesn't really matter, does it? you can just ask git to give you a diff over a list of commits, same as with a single commit.

I think the important thing is that a PR is treated as 1 change, and that merging it is the trigger for sending emails etc

yes, that I can get on board with

you still need to track which PRs have been processed for mail sending and stuff

What having 1 PR == 1 commit would simplify is the attic and tagging, because you only need to examine the 1 commit, going back and trying to examine individual commits is much harder especially considering merges

Then I don't think you have to track anything, you just have a hook/GitHub action/whatever that runs when a merge happens and does whatever is needed for that commit