XSF Editor Team - 2022-12-21

  1. emus has left

  2. Daniel has left

  3. Tobi has left

  4. Tobi has joined

  5. Tobi has left

  6. Tobi has joined

  7. Tobi has left

  8. Tobi has joined

  9. MSavoritias (fae,ve) has joined

  10. Daniel has joined

  11. Daniel has left

  12. Daniel has joined

  13. wurstsalat has joined

  14. emus has joined

  15. wurstsalat has left

  16. wurstsalat has joined

  17. jonas’

    what would it simplify if we do not use commit notifications?

  18. jonas’

    (I'm still not convinced those wouldn't be a significant step down from the current emails)

  19. moparisthebest

    merging a PR can trigger any emails in whatever format desired, and you don't have to bother with verifying things happen in the same commit in a list of any commits which may include merge commits, just in 1 commit, because you are only ever dealing with 1 commit

  20. moparisthebest

    basically all the issues now that start with "go through a list of commits..." can just be applied per PR, which seems to vastly simplify the entire thing, no? and I think the only thing it breaks is you can't have 1 PR publish multiple versions of a XEP, which seems good actually?

  21. moparisthebest

    Sorry now I have to go to sleep, damn timezones :)

  22. jonas’

    good night :)

  23. jonas’

    the 1 commit vs. list of commit thing doesn't really matter, does it? you can just ask git to give you a diff over a list of commits, same as with a single commit.

  24. Kev has joined

  25. Kev has left

  26. MSavoritias (fae,ve) has left

  27. MSavoritias (fae,ve) has joined

  28. soul has left

  29. soul has joined

  30. MSavoritias (fae,ve) has left

  31. MSavoritias (fae,ve) has joined

  32. soul has left

  33. soul has joined

  34. winfried has left

  35. soul has left

  36. soul has joined

  37. winfried has joined

  38. soul has left

  39. soul has joined

  40. Kev has joined

  41. Kev has left

  42. Kev has joined

  43. Kev has left

  44. moparisthebest

    I think the important thing is that a PR is treated as 1 change, and that merging it is the trigger for sending emails etc

  45. jonas’

    yes, that I can get on board with

  46. jonas’

    you still need to track which PRs have been processed for mail sending and stuff

  47. moparisthebest

    What having 1 PR == 1 commit would simplify is the attic and tagging, because you only need to examine the 1 commit, going back and trying to examine individual commits is much harder especially considering merges

  48. moparisthebest

    Then I don't think you have to track anything, you just have a hook/GitHub action/whatever that runs when a merge happens and does whatever is needed for that commit

  49. Daniel has left

  50. tmolitor has left

  51. Daniel has joined

  52. tmolitor has joined

  53. soul has left

  54. soul has joined

  55. Tobi has left

  56. Tobi has joined

  57. Tobi has left

  58. Tobi has joined

  59. Kev has joined

  60. wurstsalat has left

  61. wurstsalat has joined

  62. wurstsalat has left

  63. wurstsalat has joined

  64. wurstsalat has left

  65. wurstsalat has joined

  66. MSavoritias (fae,ve) has left

  67. MSavoritias (fae,ve) has joined

  68. MSavoritias (fae,ve) has left

  69. Millesimus has left

  70. Millesimus has joined

  71. soul has left

  72. soul has joined

  73. moparisthebest has left

  74. moparisthebest has joined

  75. Tobi has left

  76. Tobi has joined

  77. larma has left

  78. larma has joined

  79. wurstsalat has left