XSF Editor Team - 2023-01-09


  1. Kev

    I'm looking at https://github.com/xsf/xeps/pull/1262 at the moment. As far as I can tell it's got approval from the authors (although unaddressed feedback on list). It also has the wrong version block, so I've shoved Needs Version Block on it. jonas’ If you were handling this, would you update the version block yourself, squash and merge, or wait for list discussion to die down, or wait for the version block to be updated?

  2. jonas’

    Kev, if the community disagrees with the authors, that's not my beef to settle

  3. jonas’

    I don't squash tho, I use --amend on the commit

  4. jonas’

    (though that's potato potato here because only one commit)

  5. Kev

    Ta.

  6. jonas’

    important is to force-push your changes to the PR branch

  7. jonas’

    otherwise github won't notice the merge

  8. Kev

    Ta.

  9. jonas’

    (and normally you'd label it with Ready To Merge so that other editors™ know it's ready)

  10. jonas’

    (while leaving Needs Version Block in place to also let them know they can't just hit Merge)

  11. Kev

    Ta.