XSF Editor Team - 2023-02-06

  1. emus has left

  2. Tobi has joined

  3. Tobi has left

  4. Zash has left

  5. Zash has joined

  6. Zash has left

  7. Zash has joined

  8. Tobi has joined

  9. Kev has left

  10. Kev has joined

  11. Tobi has left

  12. Zash has left

  13. Zash has joined

  14. Zash has left

  15. Zash has joined

  16. Tobi has joined

  17. me9 has joined

  18. Zash has left

  19. Zash has joined

  20. me9 has left

  21. wurstsalat has joined

  22. MSavoritias (fae,ve) has joined

  23. emus has joined

  24. Kev

    I don't think we even squash on merge.

  25. Zash has left

  26. Zash has joined

  27. Tobi has left

  28. Tobi has joined

  29. Link Mauve has left

  30. Kev has left

  31. Kev has joined

  32. tmolitor

    but you could (I remember jonas doing this in the past).

  33. tmolitor

    I guess I'll squash it myself and force push the update...

  34. tmolitor


  35. Kev


  36. tmolitor

    no problem, I just needed to know what you wanted :)

  37. jonas’

    no, I never squashed

  38. jonas’

    nor do I endorse squashing

  39. tmolitor

    well you squashed at least once, if I recall correctly...but well...doesn't really matter, I guess...

  40. jonas’

    don't confuse squash with "please clean up your commit history" ;-)

  41. tmolitor

    isn't that in most cases more or less the same? ;)

  42. jonas’

    no :-)

  43. Kev

    On the other hand, I'm a big fan of squashing appropriately, and think merge commits are largely evil :D

  44. moparisthebest

    I have a proposal to get rid of manual attic management by just avoiding merges and only allowing single-commit-PRs (which you could do by policy or squashing) but no one has commented on it yet :) (in the tooling issue)

  45. tmolitor

    I cleaned up the XEP-0388 commit history in PR1214, too...should be ready to merge now :)

  46. tmolitor

    (I squashed everything into one commit)

  47. tmolitor

    only thing that confuses me: > [FAIL] XPATH value /xep/header/approver/text() ('') does not equals 'Board' or 'Council' (but should).

  48. tmolitor

    should I add an approver in my PR?

  49. soul has left

  50. soul has joined

  51. me9 has joined

  52. emus has left

  53. emus has joined

  54. larma

    tmolitor, that's what I did for past PRs, makes editor's live slightly easier if you already do it for them I guess

  55. tmolitor

    Okay, last time I did this, Dave told me that this was wrong because experimental xeps don't need council to be updated...

  56. tmolitor

    larma: what value are you using?

  57. larma


  58. larma

    well, they don't need council for updates

  59. larma

    but they need council to be approved to stable 😀

  60. Kev

    It's not an approver in the sense of a person who has approved them, it's an approver as in the body that's responsible for the advancement of the XEP.

  61. Kev

    Assuming we're talking about what I think we're talking about.

  62. moparisthebest

    tmolitor, larma, Kev: I have a PR to add approver to all where it's missing, can it be merged?

  63. Kev

    When I'm not ill, I'll try to do another chunk of PR triages.

  64. stpeter has joined

  65. Tobi has left

  66. Tobi has joined

  67. Tobi has left

  68. Tobi has joined

  69. Tobi has left

  70. Tobi has joined

  71. Tobi has left

  72. Tobi has joined

  73. Tobi has left

  74. Tobi has joined

  75. Tobi has left

  76. Tobi has joined

  77. moparisthebest has left

  78. moparisthebest has joined

  79. tmolitor

    Well, i guess Dave was wrong then...the xep template needs to be updated, I guess

  80. tmolitor

    I'll do another force push to PR 1214 to add approver=council there...

  81. tmolitor

    PR 1214 is wrongly labeled by the way

  82. stpeter has left

  83. moparisthebest

    I also have a PR to automate labeling :(

  84. stpeter has joined

  85. stpeter has left

  86. Tobi has left

  87. Tobi has joined

  88. Tobi has left

  89. Tobi has joined

  90. soul has left

  91. soul has joined

  92. Tobi has left

  93. me9 has left

  94. MSavoritias (fae,ve) has left

  95. Tobi has joined

  96. tmolitor

    those automation prs sound really helpful....but then again I'm not an editor anyways...

  97. tmolitor

    I've updated the XEP-0388 PR (1214) to include an approver and squashed everything into one single commit :)

  98. Kev has left

  99. Kev has joined

  100. wurstsalat has left

  101. Tobi has left

  102. Kev has left

  103. Kev has joined