XSF Editor Team - 2023-02-06

  1. Kev

    I don't think we even squash on merge.

  2. tmolitor

    but you could (I remember jonas doing this in the past).

  3. tmolitor

    I guess I'll squash it myself and force push the update...

  4. tmolitor


  5. Kev


  6. tmolitor

    no problem, I just needed to know what you wanted :)

  7. jonas’

    no, I never squashed

  8. jonas’

    nor do I endorse squashing

  9. tmolitor

    well you squashed at least once, if I recall correctly...but well...doesn't really matter, I guess...

  10. jonas’

    don't confuse squash with "please clean up your commit history" ;-)

  11. tmolitor

    isn't that in most cases more or less the same? ;)

  12. jonas’

    no :-)

  13. Kev

    On the other hand, I'm a big fan of squashing appropriately, and think merge commits are largely evil :D

  14. moparisthebest

    I have a proposal to get rid of manual attic management by just avoiding merges and only allowing single-commit-PRs (which you could do by policy or squashing) but no one has commented on it yet :) (in the tooling issue)

  15. tmolitor

    I cleaned up the XEP-0388 commit history in PR1214, too...should be ready to merge now :)

  16. tmolitor

    (I squashed everything into one commit)

  17. tmolitor

    only thing that confuses me: > [FAIL] XPATH value /xep/header/approver/text() ('') does not equals 'Board' or 'Council' (but should).

  18. tmolitor

    should I add an approver in my PR?

  19. larma

    tmolitor, that's what I did for past PRs, makes editor's live slightly easier if you already do it for them I guess

  20. tmolitor

    Okay, last time I did this, Dave told me that this was wrong because experimental xeps don't need council to be updated...

  21. tmolitor

    larma: what value are you using?

  22. larma


  23. larma

    well, they don't need council for updates

  24. larma

    but they need council to be approved to stable 😀

  25. Kev

    It's not an approver in the sense of a person who has approved them, it's an approver as in the body that's responsible for the advancement of the XEP.

  26. Kev

    Assuming we're talking about what I think we're talking about.

  27. moparisthebest

    tmolitor, larma, Kev: I have a PR to add approver to all where it's missing, can it be merged?

  28. Kev

    When I'm not ill, I'll try to do another chunk of PR triages.

  29. tmolitor

    Well, i guess Dave was wrong then...the xep template needs to be updated, I guess

  30. tmolitor

    I'll do another force push to PR 1214 to add approver=council there...

  31. tmolitor

    PR 1214 is wrongly labeled by the way

  32. moparisthebest

    I also have a PR to automate labeling :(

  33. tmolitor

    those automation prs sound really helpful....but then again I'm not an editor anyways...

  34. tmolitor

    I've updated the XEP-0388 PR (1214) to include an approver and squashed everything into one single commit :)