XSF Editor Team - 2023-02-28

I've written a script that polls GitHub for the list of open PRs, and runs triage.sh on each of them. I don't know that this will be useful to anyone else, but I'll commit it to the repo anyway.

Yes, commit all the things!

+1 :)

Ideally we can run that with GitHub actions to automatically apply tags, but boy do I hate the dev cycle of doing that

Tweak yaml, push, wait, repeat 999999 times

I don't think the script is ready for automatic running yet, I was having to apply Human Brains to do sensible things with the output.

``` ➜ xeps (master) ✗ ./tools/local-triage.py 42 PRs PR#1272(Flowdalic:stanza-id-references): XEP-0359 (STANZA-ID): Add security consideration and <referenced-stanza/> Check labels (c), Open on GitHub (o) or skip (enter):c remote: Enumerating objects: 9, done. remote: Counting objects: 100% (8/8), done. remote: Compressing objects: 100% (3/3), done. remote: Total 5 (delta 3), reused 3 (delta 2), pack-reused 0 Unpacking objects: 100% (5/5), 1.48 KiB | 1.48 MiB/s, done. From github.com:xsf/xeps * branch refs/pull/1272/merge -> FETCH_HEAD info: XEP-0359 status 'Experimental' needs approvers: 'flo@geekplace.eu' error: version is not semver format: '0.7' Worktree checked out in pr-worktree/1272 Enter to remove worktree and continue PR#1271(jcbrand/xep-0425-remove-fastening): XEP-0425: Updates based on list feedback Check labels (c), Open on GitHub (o) or skip (enter): ``` This is what the wrapper does. I'm not sure of its value, but it saves me some annoyance for now.

Sometimes, just sometimes, git worktrees are the greatest thing ever.

What do you have to do manually? The plan was to grep for tags and put the rest of the output in a comment

I forget. It not understanding authors was one, it flagging things as needing council or author or whatever when really they need changes because they don't build was another. I think there might have been more, but I'm not sure.

I'm treating the script as a useful advisory tool for the moment, anyway.

(thank you)

I plan on implementing the mailmap thing guus suggested so it can understand all emails etc, if you have other suggestions let me know

Or, make an issue or something, otherwise I'll forget :D

Actually, I think I could probably use `gh` itself to find that the build is failing, in my script, and not bother calling your script in that case. So maybe just the Author aliasing would be enough in your script.

I guess in a GitHub action my script wouldn't even run unless the build and guus' script were successful

That might be true.

I'm somewhat keen to use it out of CI for a bit anyway, to be sure it's not going to confuse me too much.

Seems sensible to me

Because, as I need to send mails to Authors and Council etc., it's somewhat helpful for me to do that when I apply the label.

couldn't that emails mostly be automated, too?

Otherwise the odds of me not screwing up get even smaller than they already were.

Maybe, can we send emails from github actions?

Add a --check (or what's the flag?) so that it doesn't do anything? But run it anyway?

The script

If it's gonna do more than apply labels and make a comment I'd really vote for more testing first :)

pep.: --dry-run :)

That

kev: could the build error of my protoxep be an error in the dtd?

inbox/xep-scram-upgrade.xml:43: element p: validity error : Element a is not declared in p list of possible children as far as I know it should be possible to link other documents...

(or to an anchor in the same document, like in this example)

IIRC XEPs use <link> or something, rather than <a>

(I know, it's confusing)

ah sorry, its <link/> instead of <a/>, I'm sorry...

I'll fix that :)

The process is working! :)

🎉️

:D

Kev: fixed :)

I trying to compile XEP updates in February for the newsletter, but I received 0 mails regarding XEP updates from the editor (standards@) this month 🤔️

Yep thats right

But kev is catching up now :)

"Everyone was exhausted after Summit & FOSDEM" ... or maybe just something about Editor working on improving the tooling?

pit stop? :)

> pit stop? :) ?

The thing racing cars do, mid-race maintenance and refueling ✏

aaahh, well, yes :D :D

now kev is refueled :D