jdev - 2020-04-02

What is the purpose of `TRAVIS_TAG:-` on the first line below (characters 23 trough 34)? ``` $ export TRAVIS_TAG=${TRAVIS_TAG:-$(date +'%Y%m%d')-TRAVIS_BUILD_NUMBER_$TRAVIS_BUILD_NUMBER-$(git log --format=%h -1)} $ echo $TRAVIS_TAG 20200402-TRAVIS_BUILD_NUMBER_-c74cade ```

It doesn't seem to be included in the exported value?

Guus, ${foo:-bar} defaults the expression to `bar` if `foo` is not defined

the `-` is part of the syntax

ah!

then it seems this construct is a mismatched combination of copy/paste

why?

TRAVIS_TAG is never defined.

you sure?

well, it shouldn't.

then I suggest not exporting a variable named like something the CI server could set ;)

or should it... hmm.. wI didn't _expect_ it 🙂

if i get a disco info request to my full jid

with a node that resembles entity caps

should i check if the hash is my current hash

and if not probably answer with an error or not?

because 0115 does not mention anything about in what cases one should return an error

and what error that would be

lovetox, smack caches the last N caps and will return the information

sound wrong to me

but maybe I don't get the question. the answer seems trivial to me: if you can answer the query, the answer it, otherwise response with an error

lovetox, how come?

but doesnt answer my question, you assume someone sends a hash that existed in the past

ok, then I probably don't understand the question

i send a disco info request with node="lovetoxlovesdisco"

what does smacks answer?

assuming the node does not exists, hopefully whatever xep30 specifies to return in that case

https://xmpp.org/extensions/xep-0030.html#errors

item-not-found

lovetox, does that help?

(or, does it sound right?)

yeah thats what i thought, item-not-found seems to fit

just find it weird that 115 neither say anything about checking the node hash, nor notes any error cases

for example Gajim does not check the node hash, and just returns its disco info

which seems pretty bad

indeed

tbh, I wouldn't expect that xep115 has to say anything about this, as its all within the realm of xep30 ✏

do have some kind of node register functionality

it seems more than one xep uses disco

like adhoc which can have various nodes

but its not clear if we receive a disco for what module it is

entity caps, ad hoc, or something else

there is no xep namespaces here

well it should be clear to the receiving entity if there is something behind that node or not

yeah but how do you implement that in a library

you have multiple modules, and they register their nodes in some kind of service

hmm? I don't see a problem, smack obviously did

which routes the iq then to correct module

im asking you flow

how you did it

you only have an issue if there is a clash in the node name

and to prevent those we have https://github.com/xsf/registrar/blob/master/nodes.xml

lovetox, smack's entity caps manager tells the service discovery manager to return X on a disco info request to node Y

ok so modules register their nodes in some kind of service

yap

yeah seems good, sigh, more work, it never ends

its similar to how modules can register for IQ requests

just in this case, it's limited to a particular IQ and involves nodes (the often unknown and misunderstood concept of XMPP)

ok thanks :)

always happy to help :)