jdev - 2020-04-09

I've reworked Openfire pubsub code. Can anyone suggest some ways to do some quick functional tests?

I've ran the Smack Integration Tests, which seem to be fine - but those don't go into much detail. I'd like to run some additional tests, preferably not ones created by me.

aioxmpp has some PEP related tests for sure, and very bare PubSub tests

jonas’ cool - how do I run them?

Guus, git clone https://github.com/horazont/aioxmpp, you may be able to get some inspiration from https://github.com/horazont/aioxmpp/blob/devel/utils/travis-e2etest-ejabberd.py

if you adapt the scripts and configs in that repository to work with openfire, that’d be amazing

My understanding of the python language is that 'hssssssss' means that you should step away.

that py file I linked you is more of a glorified shell script really. I can’t guide you at this moment, I’m supposed to be in a meeting in four minutes

kk, tx

There must be a better way to figure out what modules are needed other than to try and run it, see an error, and install that?

ah: https://docs.zombofant.net/aioxmpp/devel/user-guide/installation.html

I was looking under 'developer guide' 🙂

hmm, still missing modules

ohh, pip3 install -e .

look ma, I can do python

Look ma, no jvm!

heheeh

hmm, it doesn't like Openfire's self-signed certs, even when setting the no_verify option

openssl no_verify?

ah, it helps if you don't have a typo in "no_verify" (jonas: there's a typo in the documentation as well as in the ejabberd config file)

Guus, ever tried running scansion against Openfire?

no. I'd like to.

Ran 4503 tests in 76.160s FAILED (SKIP=4, errors=19, failures=5)

That's an impressive amount of tests.

Loooots of output - might need some help interpreting

Guus, note that most of these are not end-to-end

before you go further, what’s the output of python3 --version?

Python 3.6.9

We're disabling SASL anon by default. Can you share the configuration for a simple username/password auth?

Guus, unfortunately, not

it needs multiple connections usually

(with different accounts)

hmm, that makes it harder to put in our CI

I’m not sure if I ever developed the "pre-provisioned account" mode

I planned for it, but I think I simply never needed it

Implement (in OF) a mode that simply accepts any username+password?

then you still need (in aioxmpp) a mode which uses random username/password

It's all doable, but not today 🙂

same here :)

but I’d love to test against OF in the CI -- but I never got around to set it up

jonas’ : https://github.com/igniterealtime/Openfire/blob/master/runIntegrationTests

that's what we use for Smack's integration tests

probably more elaborate than what it needs to be

but it launches an openfire instance, and runs the tests

(Smack's implementation require an account that's allowed to create other accounts)

apart from needing to enable SASL anonymous, it worked pretty much out of the box

[global] provisioner=aioxmpp.e2etest.provision.AnonymousProvisioner [aioxmpp.e2etest.provision.AnonymousProvisioner] domain=cluster.goodbytes.im host=cluster-a.goodbytes.im no_verify=true

(note that at some point, that domain goes away - I'm using it for testing only)

Zash, how do I run scansion?

heck, how do I _find_ it. Googling for prosody scansion gives me linguistic results. 🙂

https://matthewwild.co.uk/projects/scansion/

is there a repo of scripts?

There's a bunch in the Prosody repo: https://hg.prosody.im/trunk/file/tip/spec/scansion

Those are written expecting that arbitrary username/passwords are accepted

Doesn't seem to like my self-signed cert either

Pretty sure we run our CI with TLS disabled

Prosody config is in the same directory

hmm... doesn't help

does it do DNS SRV lookups?

the domain in the JID does not resolve with an A record.

Probably

https://igniterealtime.org:443/httpfileupload/94c20187-8fa0-4f98-9d0f-0a1869538173/image.png

Unsure what to make of that

jonas’ I'd be greatful if you can help me interpret the gazillion lines of logs generated by your tests.

screenshot of text :|

Guus: I think you need to trick docker into letting it have access to where your xmpp server is running

screenshot of text to preserve format - didn't assume anyone wanted to copy stuff from this 🙂

ah, it does not have access by default?

"connection refused" is the relevant thing I assume

my docker is as good as my python

sure

but ... why 🙂

Try `--network host` maybe?

Where is specified how a message should look like when sending the link to a http-uploaded file OOB? Or how is it done that clients show the file instead of the link? ✏

Docker is so last years, now it's Kubernetes all the things!

Martin, I think this is implementation dependend

Martin, source code of Conversations probably

Yeah, code == specification? ;-(

In theory you just follow XEP-0066

In practice I think you must have the URL both in that and in <body>, and nothing else

Thanks, will figure out.

I'm kinda sad that you can't include a description, which is supported by OOB.

Did anyone get anywhere with XEP-0385 yet?

Psi supports 385

But currently implementation is incomplete. Works for images and audio messages only. And has some bugs.

> In practice I think you must have the URL both in that and in <body>, and nothing else Ok, that worked. Thanks. 😃

> I'm kinda sad that you can't include a description, which is supported by OOB. That would be really nice.

Guus, send them to me via email or something

Is it safe to assume that the max file size is always in the value of the second field of the second x in the reply to disco#info?

For the http upload service

Martin, that sounds wrong

Martin, why not use the field's name?

and why *second* <x/>?

wat

Worked here for dismail (ejabberd) and my own server (prosody). Dunno how to access by name without cycling through all.

Martin, that is very fragile

so it is *definetly* not safe and unsound

Zash, movim also has 385 support

Ok, then I'd better go through all and check the names.

Martin, what language and xml library are you using?

aah, trick question by Zash ;) ✏

pep., /react nice

DISCLAIMER: I am no dev so probably I am holding it wrong anyway.

I am using go and github.com/mattn/go-xmpp

Martin, no worries. but you definetly should not settle for quick hacks, especially if they fragile

I did create a struct with the structure of the xml and then xml.Unmarshal the IQ reply into it.

Martin, you can easily become a developer if you go into your Android settings and tap on "Build number" multiple times. Then it will say "You are now a developer!"

that alone sounds worrisome. due to the extensible nature of XMPP the returned XML may not match your struct ✏

It's that easy

Looking at the output it seems the max-file-size is in the value of the second field on the first and second x. But if this is not standardized I will check for the "max-file-size" in var while cycling through all.

Martin, it *is* standardized

You need to own a device with android, it's the only requirement for being a developer

pep.: Did that several times already on all of my phones. Thanks, no I can not hide behind "I'm no dev" anymore. :(

Martin, it is the value of the max-size-field of the extended disco info form with the type urn:xmpp:http:upload:0

Ok. So it is important to check the field name. That's what I wanted to know. Thanks. :)

Martin, not only the field name, you also have to check that you are looking at the right form

About the issue that the struct might not matching if/when something there get's extended I don't know what to do, as somehow I must get the date of that byte array into something I can process.

flow: Meh, why everything must be complicated…

I don't think it is complicated, nor that there is a much simpler alternative

you could extra the value with a pull parser

or mayben even an xpath expression

Hmm, that would be two new things to read up. ^^

always a good idea to learn new things :)

It's always exponential growth, I want to do one thing than I need look up three things for that. Number 1 requires me to look up 4 other things, number two requires me to look up 2 new things and numer 3 requires me to look up 3 new things. And every level 2 new thing requires me to look up n level 3 new things. It's never ending. I, as an engineer, don't understand how you devs ever finished your studies because everything is a hydra. ^^

the secret is: we are always studying and shaving yaks

You never shave Ge0rg, his avatar is as hairy as always!

So, you think this is sufficient for determining the max-file-size or is it still fragile? https://salsa.debian.org/mdosch-guest/go-sendxmpp/-/commit/9702df6c84a189fbf881c29c9ba07d3e77ae84c8

Martin, it is far better, but AFAIKT you do not check if you look at the right form

What to check for? I don't see anything interesting for FORM:

<iq id='1eda7aa0-fd912ef9-30805dc5' type='result' to='go-sendxmpp@mdosch.de/go-sendxmpp' from='files.mdosch.de'> <query xmlns='http://jabber.org/protocol/disco#info'> <identity type='file' name='HTTP File Upload' category='store'/> <feature var='http://jabber.org/protocol/disco#info'/> <feature var='http://jabber.org/protocol/disco#items'/> <feature var='urn:xmpp:http:upload:0'/> <feature var='urn:xmpp:http:upload'/> <x type='result' xmlns='jabber:x:data'> <field type='hidden' var='FORM_TYPE'> <value>urn:xmpp:http:upload:0</value></field> <field type='text-single' var='max-file-size'> <value>104857600</value></field> </x> <x type='result' xmlns='jabber:x:data'> <field type='hidden' var='FORM_TYPE'> <value>urn:xmpp:http:upload</value></field> <field type='text-single' var='max-file-size'> <value>104857600</value></field> </x>

Or do you mean to check which is the http upload component? That's done there: https://salsa.debian.org/mdosch-guest/go-sendxmpp/-/blob/http_upload/httpupload.go#L141

Martin, I think he meant checking FORM_TYPE?

Ok, what is that good for? No need feed me with a golden spoon just direct me at the right xep. But all I see is `<field type='hidden' var='FORM_TYPE'>` which seems quite uninteresting for me.

Martin, the value of that field is what indicates what type of field it is

Which fields you may find in it

Ah, so I need to check for `urn:xmpp:http:upload:0`. Ok thx.

yeah

Ok, am checking for this as well now.

Thanks all for the useful feedback. 😃 If you feel bored someday you can go through the rest, tell me what I'm doing wrong there. 😂

what priority do i have to set if i dont want to use priority

lovetox, define "do not want to use priority"

i just read i can just leave it out of the presence

then server assumes 0

that's right

does it do anything if i include priority in a presence to a MUC?

that's a good question. I think the priority in directed presence stanzas it not used anywhere

but I could be wrong. A server dev could may say more about this

but then again, *why* do you want to include a priority value in a directed presence?

i dont want to, and i dont do it

but i have no rational for it