-
Guus
lovetox would you please add the request that you used to trigger the MAM bug you just reported in the ticket?
-
lovetox
yes np
-
Guus
tx! Looking at it right now
-
lovetox
Guus maybe you cant reproduce because you didnt include a rsm element
-
Guus
that might be it. I did get one in the resulting 'fin'
-
Guus
I'll have a look. Thanks for the report.
-
lovetox
hm i see at least one thing that can be improved on Gajim side, i only include the date filter on the first query
-
Guus
lovetox this might be caused by the query returning data that was stored prior to Openfire supporting MAM:2
-
lovetox
Guus i adjusted Gajim so it always includes the date filter in every page request
-
lovetox
the problem is still there
-
lovetox
so the server definitly does not look in the database for messages older than a day
-
lovetox
or he wouldnt need to from my query
-
lovetox
not sure what it really does
-
Guus
I'm thinking it doesn't include a first or last element if the corresponding message does not have a stable id
-
Guus
lovetox would you mind retrying on ignite?
-
Guus
I've rolled out a build that contains a fix
-
Guus
A snapshot release for the plugin will appear momentarily on https://www.igniterealtime.org/projects/openfire/plugin-archive.jsp?plugin=monitoring
-
Guus
this includes the fix, which you can use to test on other domains.
-
lovetox
Guus, looks good now
-
Guus
lovetox: cool, tx
-
Guus
This might fix quite a bit of oddities around archive interaction in older MUCs.
-
Zash
Does anyone happen to feel like writing a kind of echo bot that tries to answer in the users language? Ie, reply "Hello" translated based on stanza @xml:lang
-
jonas’
and make it finish with "Das war: $Language"
-
Martin
Sendung mit der Maus?
-
pep.
Or "Hello in English!" "Bonjour en français !"
-
Zash
Something to test how well xml:lang gets across the network.
-
jonas’
Martin, YES!
-
Martin
As I see different clients using different styles of IDs for messages I assume there is no definition how they should look like. Is this right?
-
jonas’
Martin, correct
-
Martin
Thanks.
-
lovetox
hm anybody an idea why ejabberd would remove my delay element which i added to a stanza
-
lovetox
<delay xmlns="urn:xmpp:delay" stamp="2020-04-11T16:03:18Z" from="lovetox@temptatio.dev/gajim.09IQM0NS" />
-
lovetox
Holger ^
-
Holger
lovetox: No, and I can't reproduce it.
-
Holger
lovetox: If you can maybe we should continue in the ejabberd room?
-
Holger
(Protocol-wise, the only reason to strip a delay tag I see would be you setting an incorrect `from` address.)
-
Zash
Or a `from` of the server itself.
-
Zash
Or basically anything that's not your own full JID
-
lovetox
yeah, but we know no server validates delay tags
-
lovetox
so even then ..
-
lovetox
i think i have an idea
-
lovetox
hm i think thats a bug on my side
-
lovetox
:/
-
flow
I hear such things happen :)
-
lovetox
i wonder how do people implement the resend of stanzas after resumption
-
lovetox
currently i pass the stanza to the socket to send, but keep it around, add the delay element, and put it into a queue
-
lovetox
but this poses the danger that i accidently for some reason have a reference somewhere else to that stanza and modify it after sending
-
lovetox
and on resend i send something different then
-
lovetox
now i could create a copy of the stanza before i queue it, but i wonder if its worth the overhead
-
Zash
I think the 198 implementation for Prosody also copies. Or it should. But that costs memory allocations.
-
lovetox
the problem is i dont think my node structs are easily copyable
-
lovetox
if i do it now, i would convert it to a string, and reparse it into a new node
-
Zash
true immutable data structures would have been nice
-
lovetox
which is damn awful
-
Zash
costs memory tho