jdev - 2023-02-28

  1. nicoco

    Zash, pep.: groupchat messages from room bare JID broke gajim https://dev.gajim.org/gajim/gajim/-/issues/11417 😬️

  2. pep.

    oops?

  3. nicoco

    oops indeed. 😁️ I can change it in slidge, but it's not clear to me if it's (in)correct behaviour… it feels right to map "system messages" this way. OTOH, it's really easy for me to set the room name as the resource, so I can do that too. not sure what's best

  4. pep.

    That's weird though, to use the room name as resource name. It's not a participant

  5. goffi

    what if a participant has the room name as nickname?

  6. jonas’

    nicoco, don't do that, biboumi also uses it for system messages, gajim shouldn't break :) ✎

  7. goffi

    using room bare JID looks like the right way to send system message to me.

  8. jonas’

    nicoco, don't do that, biboumi also uses the bare JID for system messages, gajim shouldn't break :) ✏

  9. nicoco

    > what if a participant has the room name as nickname? exactly why I prefer the room bare JID option :)

  10. nicoco

    jonas': oh OK, pep. mentioned that without being sure but I never saw gajim break on my biboumi-ed rooms. maybe my stanzas are wrong somehow or maybe gajim has special treatment for what it detects as biboumi-ed rooms? they are definitely detected as such, with an IRC logo as the room avatar. I'll do some more digging, maybe I filed an issue too quickly.

  11. pep.

    Maybe you have never seen a mode change that isn't easily translatable to XMPP

  12. nicoco

    I am not in a lot of IRC rooms indeed, so that is possible indeed ✎

  13. nicoco

    I am not in a lot of IRC rooms, so that is possible indeed ✏

  14. wurstsalat

    nicoco: thanks for the report. I fixed that once already. Need to fix it twice, I guess ┐⁠(⁠ ⁠∵⁠ ⁠)⁠┌

  15. MattJ smells a lack of tests ;)

  16. nicoco usually has 1 automated test in his projects, since it's enough for the nice green badge in the README ^^

  17. nicoco

    wurstsalat: great!