jdev - 2023-04-02


  1. edhelas

    https://github.com/processone/ejabberd/issues/3591

  2. edhelas

    ejabberd doesn't implement (yet) urn:xmpp:bookmarks:1#compat-pep, if you want to push it a bit, do not hesitate to leave a comment there :)

  3. nicoco_

    When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?

  4. jonas’

    it's better to always set publish-options in order to avoid publishing to an incorrectly configured node

  5. jonas’

    (such as one which is set to open)

  6. Zash

    Did we do a discovery method for "max" ?

  7. Link Mauve

    nicoco_, we probably should replace 10000 with max in the spec.

  8. pep.

    Zash, good question.. Maybe we can postpone the latest pubsub PR :x

  9. Zash

    Link Mauve, yes!

  10. Link Mauve

    https://github.com/xsf/xeps/pull/1278

  11. Link Mauve

    Also, https://github.com/xsf/xmpp.org/pull/1261

  12. edhelas

    > When adding (or updating) a XEP 0402 bookmark, must &lt;publish-options&gt; always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Also it breaks with ejabberd for now :p

  13. edhelas

    https://github.com/processone/ejabberd/issues/3044

  14. nicoco_

    Thanks for your replies!

  15. singpolyma

    > When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Wow, only 256??

  16. Zash

    Wow, only 256 concurrently playing songs each with their own mood?

  17. lovetox

    nicoco_, no its not ok to publish with some magic number

  18. lovetox

    imagine everyone would do this, nobody would have the same number, on every bookmark change node is reconfigured

  19. lovetox

    just dont set this configuration, because its not universal supported

  20. nicoco_

    lovetox: you’re against the idea of using ‘max’ here?

  21. lovetox

    max s not a number

  22. singpolyma

    > Wow, only 256 concurrently playing songs each with their own mood? Right?

  23. lovetox

    you suggested using a number

  24. singpolyma

    FWIW we use "max" in our bookmarks2 publish options

  25. lovetox

    then you dont publish bookmarks on ejabberd?

  26. Zash

    singpolyma, keep in mind that we don't have RSM in our pubsub implementation and a pubsub items query would return all of them

  27. lovetox

    and on some other servers, and on old prosody serversetc...

  28. lovetox

    or you handle the weird non descriptive error with guessing that max is not supported

  29. lovetox

    because for example ejabberd will not tell you that max is not supported

  30. lovetox

    it will just abort your publish with some generic error

  31. nicoco_

    lovetox: I was referring to the example in XEP0402, I should have phrased better, eg, ‘why is this 10000 value there and is there any reason I should not use ‘max’’ here? 😉

  32. singpolyma

    > then you dont publish bookmarks on ejabberd? ejabberd doesn't support bookmarks2

  33. nicoco_

    In my case, ejabberd not supporting is not an issue, since I need xep0356 latest version with ‘IQ on behalf’ support, cf https://github.com/processone/ejabberd/issues/3889

  34. lovetox

    nicoco_, then i misunderstood, yes this value should not be in the example, i think its an oversight

  35. nicoco_

    lovetox: it triggered an insta-PR from Link Mauve :)