ejabberd doesn't implement (yet) urn:xmpp:bookmarks:1#compat-pep, if you want to push it a bit, do not hesitate to leave a comment there :)
rubihas left
rubihas joined
singpolymahas left
jgarthas left
oshnhas left
adxhas left
singpolymahas joined
adxhas joined
Tobihas left
Tobihas joined
miruxhas left
miruxhas joined
singpolymahas left
Laurahas joined
larmahas left
atomicwatchhas left
rubihas left
rubihas joined
atomicwatchhas joined
atomicwatchhas left
singpolymahas joined
atomicwatchhas joined
atomicwatchhas left
atomicwatchhas joined
atomicwatchhas left
marc0shas left
atomicwatchhas joined
atomicwatchhas left
rubihas left
rubihas joined
Tobihas left
atomicwatchhas joined
atomicwatchhas left
Tobihas joined
marc0shas joined
atomicwatchhas joined
techmetx11has left
marc0shas left
oshnhas joined
techmetx11has joined
marc0shas joined
rubihas left
rubihas joined
singpolymahas left
larmahas joined
nicoco_has left
nicoco_has joined
singpolymahas joined
rubihas left
rubihas joined
marc0shas left
marc0shas joined
rubihas left
rubihas joined
sponjihas left
Laurahas left
sponjihas joined
sponjihas left
Laurahas joined
sponjihas joined
nicoco_
When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?
adxhas left
jonas’
it's better to always set publish-options in order to avoid publishing to an incorrectly configured node
jonas’
(such as one which is set to open)
marc0shas left
Zash
Did we do a discovery method for "max" ?
Link Mauve
nicoco_, we probably should replace 10000 with max in the spec.
pep.
Zash, good question.. Maybe we can postpone the latest pubsub PR :x
Zash
Link Mauve, yes!
ralphmhas left
sonnyhas left
Link Mauve
https://github.com/xsf/xeps/pull/1278
adxhas joined
Laurahas left
atomicwatchhas left
atomicwatchhas joined
atomicwatchhas left
atomicwatchhas joined
atomicwatchhas left
norayrhas joined
sonnyhas joined
Link Mauve
Also, https://github.com/xsf/xmpp.org/pull/1261
edhelas
> When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?
Also it breaks with ejabberd for now :p ↺
> When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?
Wow, only 256?? ↺
goffihas left
goffihas joined
paulhas left
paulhas joined
goffihas left
goffihas joined
Zash
Wow, only 256 concurrently playing songs each with their own mood?
lovetox
nicoco_, no its not ok to publish with some magic number
lovetox
imagine everyone would do this, nobody would have the same number, on every bookmark change node is reconfigured
lovetox
just dont set this configuration, because its not universal supported
nicoco_
lovetox: you’re against the idea of using ‘max’ here?
lovetox
max s not a number
singpolyma
> Wow, only 256 concurrently playing songs each with their own mood?
Right? ↺
lovetox
you suggested using a number
singpolyma
FWIW we use "max" in our bookmarks2 publish options
lovetox
then you dont publish bookmarks on ejabberd?
Zash
singpolyma, keep in mind that we don't have RSM in our pubsub implementation and a pubsub items query would return all of them
lovetox
and on some other servers, and on old prosody serversetc...
jgarthas left
lovetox
or you handle the weird non descriptive error with guessing that max is not supported
lovetox
because for example ejabberd will not tell you that max is not supported
lovetox
it will just abort your publish with some generic error
nicoco_
lovetox: I was referring to the example in XEP0402, I should have phrased better, eg, ‘why is this 10000 value there and is there any reason I should not use ‘max’’ here? 😉
singpolyma
> then you dont publish bookmarks on ejabberd?
ejabberd doesn't support bookmarks2 ↺
nicoco_
In my case, ejabberd not supporting is not an issue, since I need xep0356 latest version with ‘IQ on behalf’ support, cf https://github.com/processone/ejabberd/issues/3889
paulhas left
antranigvhas joined
ralphmhas joined
antranigvhas left
antranigvhas joined
sponjihas left
sponjihas joined
sponjihas left
paulhas joined
heartyhas left
antranigvhas left
heartyhas joined
sponjihas joined
lovetox
nicoco_, then i misunderstood, yes this value should not be in the example, i think its an oversight
nicoco_
lovetox: it triggered an insta-PR from Link Mauve :)