-
edhelas
https://github.com/processone/ejabberd/issues/3591
-
edhelas
ejabberd doesn't implement (yet) urn:xmpp:bookmarks:1#compat-pep, if you want to push it a bit, do not hesitate to leave a comment there :)
-
nicoco_
When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?
-
jonas’
it's better to always set publish-options in order to avoid publishing to an incorrectly configured node
-
jonas’
(such as one which is set to open)
-
Zash
Did we do a discovery method for "max" ?
-
Link Mauve
nicoco_, we probably should replace 10000 with max in the spec.
-
pep.
Zash, good question.. Maybe we can postpone the latest pubsub PR :x
-
Zash
Link Mauve, yes!
-
Link Mauve
https://github.com/xsf/xeps/pull/1278
-
Link Mauve
Also, https://github.com/xsf/xmpp.org/pull/1261
-
edhelas
> When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Also it breaks with ejabberd for now :p ↺
-
edhelas
https://github.com/processone/ejabberd/issues/3044
-
nicoco_
Thanks for your replies!
-
singpolyma
> When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Wow, only 256?? ↺
-
Zash
Wow, only 256 concurrently playing songs each with their own mood?
-
lovetox
nicoco_, no its not ok to publish with some magic number
-
lovetox
imagine everyone would do this, nobody would have the same number, on every bookmark change node is reconfigured
-
lovetox
just dont set this configuration, because its not universal supported
-
nicoco_
lovetox: you’re against the idea of using ‘max’ here?
-
lovetox
max s not a number
-
singpolyma
> Wow, only 256 concurrently playing songs each with their own mood? Right? ↺
-
lovetox
you suggested using a number
-
singpolyma
FWIW we use "max" in our bookmarks2 publish options
-
lovetox
then you dont publish bookmarks on ejabberd?
-
Zash
singpolyma, keep in mind that we don't have RSM in our pubsub implementation and a pubsub items query would return all of them
-
lovetox
and on some other servers, and on old prosody serversetc...
-
lovetox
or you handle the weird non descriptive error with guessing that max is not supported
-
lovetox
because for example ejabberd will not tell you that max is not supported
-
lovetox
it will just abort your publish with some generic error
-
nicoco_
lovetox: I was referring to the example in XEP0402, I should have phrased better, eg, ‘why is this 10000 value there and is there any reason I should not use ‘max’’ here? 😉
-
singpolyma
> then you dont publish bookmarks on ejabberd? ejabberd doesn't support bookmarks2 ↺
-
nicoco_
In my case, ejabberd not supporting is not an issue, since I need xep0356 latest version with ‘IQ on behalf’ support, cf https://github.com/processone/ejabberd/issues/3889
-
lovetox
nicoco_, then i misunderstood, yes this value should not be in the example, i think its an oversight
-
nicoco_
lovetox: it triggered an insta-PR from Link Mauve :)