jdev - 2023-04-02

https://github.com/processone/ejabberd/issues/3591

ejabberd doesn't implement (yet) urn:xmpp:bookmarks:1#compat-pep, if you want to push it a bit, do not hesitate to leave a comment there :)

When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right?

it's better to always set publish-options in order to avoid publishing to an incorrectly configured node

(such as one which is set to open)

Did we do a discovery method for "max" ?

nicoco_, we probably should replace 10000 with max in the spec.

Zash, good question.. Maybe we can postpone the latest pubsub PR :x

Link Mauve, yes!

https://github.com/xsf/xeps/pull/1278

Also, https://github.com/xsf/xmpp.org/pull/1261

> When adding (or updating) a XEP 0402 bookmark, must &lt;publish-options&gt; always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Also it breaks with ejabberd for now :p ↺

https://github.com/processone/ejabberd/issues/3044

Thanks for your replies!

> When adding (or updating) a XEP 0402 bookmark, must <publish-options> always be present? Is using ‘max’ as a value for pubsub#max_items OK? Using 10000 as a value (cf xep0402 examples) makes prosody reply with out of bounds; this is because pep_max_items=256 by default, did I understand this right? Wow, only 256?? ↺

Wow, only 256 concurrently playing songs each with their own mood?

nicoco_, no its not ok to publish with some magic number

imagine everyone would do this, nobody would have the same number, on every bookmark change node is reconfigured

just dont set this configuration, because its not universal supported

lovetox: you’re against the idea of using ‘max’ here?

max s not a number

> Wow, only 256 concurrently playing songs each with their own mood? Right? ↺

you suggested using a number

FWIW we use "max" in our bookmarks2 publish options

then you dont publish bookmarks on ejabberd?

singpolyma, keep in mind that we don't have RSM in our pubsub implementation and a pubsub items query would return all of them

and on some other servers, and on old prosody serversetc...

or you handle the weird non descriptive error with guessing that max is not supported

because for example ejabberd will not tell you that max is not supported

it will just abort your publish with some generic error

lovetox: I was referring to the example in XEP0402, I should have phrased better, eg, ‘why is this 10000 value there and is there any reason I should not use ‘max’’ here? 😉

> then you dont publish bookmarks on ejabberd? ejabberd doesn't support bookmarks2 ↺

In my case, ejabberd not supporting is not an issue, since I need xep0356 latest version with ‘IQ on behalf’ support, cf https://github.com/processone/ejabberd/issues/3889

nicoco_, then i misunderstood, yes this value should not be in the example, i think its an oversight

lovetox: it triggered an insta-PR from Link Mauve :)