-
singpolyma
The app will usually want to render it at font size. To make it look like an emoji
-
Cynthia
Yes, of course
-
Cynthia
Now that I can get by
-
singpolyma
an app basically never renders an image at the size specified in the file because UI constraints always apply. Especially in emoji case but generally also
-
Cynthia
Also by the way, can this ever be used in places like reactions?
-
singpolyma
but if I use the same image as a sticker the app may render it differently of course. None of this affects protocol
-
Cynthia
I think reactions need a Unicode emoji
-
singpolyma
I use it in reactions but not with reaction xep
-
Cynthia
So snit, I'll be modifying the ProtoXEP to remove any mentions of packs, and instead in Implementation Notes, recommend that implementations implement 0449 and use that as emoji packs if they want
-
Cynthia
and also change the ID in <emoji> to use the first hash of the SFS/SIMS element
-
vpzom
is there a standard way custom emoji should be sent in XHTML-IM without allowing all inline images?
-
Cynthia
Nobody wants to use XHTML-IM
-
vpzom
that's clearly not true
-
Cynthia
Whether it's true or not, It doesn't matter because that's not related
-
Cynthia
This ProtoXEP is about Message Markup
-
singpolyma
> is there a standard way custom emoji should be sent in XHTML-IM without allowing all inline images? Not sure I follow. Custom emoji are inline images ↺
-
vpzom
sure but they have a specific (client-dependent?) size
-
Cynthia
We don't rely on the size being in a certain range
-
Cynthia
Like singpolyma said before, emojis can be of any size, even a sticker
-
vpzom
that's two sizes
-
singpolyma
Right. Client needs to size them sanely in UI this is up to client to do
-
Cynthia
Maybe you could use the CSS in XHTML-IM to size them back down to font size
-
singpolyma
you need to assume the native "size" (resolution) of the image doesn't match the size you want to display
-
Cynthia
But I don't really know
-
singpolyma
I don't think that's really needed but our could. I apply sane sizing for all inline images
-
singpolyma
obviously I don't want someone to send an "inline image" dhsd actually renders huge. No matter what is in the file or html or css
-
Cynthia
> I don't think that's really needed but our could. I apply sane sizing for all inline images How do you handle font sizes in XHTML-IM? ↺
-
Cynthia
Do you have a cap for how large text can be?
-
singpolyma
Depends on the app. I'm most of them I don't support font size control beyond "this is smaller" (aka <small>)
-
singpolyma
I may remove all inline CSS support from all of them entirely I haven't decided. At least colour I know biboumi uses so I support that everywhere at the moment
-
singpolyma
or no, not iOS. Just android and web
-
singpolyma
but I probably would add it I'm not sure
-
Cynthia
singpolyma: Can you review https://codeberg.org/techmetx11/xeps/src/branch/master/emoji-markup.xml now?
-
singpolyma
you don't want multiple version blocks in a protoxep For hash maybe use a hash child element from the normal namespace instead of an attribute named id? I'm not a messaging markup person but pretty sure you want a span element parent not begin/end on the emoji child
-
singpolyma
I'd also avoid the old jinglepub thing in the example for simplicity etc
-
Cynthia
> you don't want multiple version blocks in a protoxep > > For hash maybe use a hash child element from the normal namespace instead of an attribute named id? > > I'm not a messaging markup person but pretty sure you want a span element parent not begin/end on the emoji child No multiple version blocks? ↺
-
Cynthia
So like, just one?
-
Cynthia
I did update it again per your other recommendations
-
Cynthia
singpolyma: Does it look fine now?
-
singpolyma
> So like, just one? Right ↺
-
singpolyma
looks great
-
snit
> So snit, I'll be modifying the ProtoXEP to remove any mentions of packs, and instead in Implementation Notes, recommend that implementations implement 0449 and use that as emoji packs if they want that'll work for me yeah. do you think it might be an issue that it only specifies SFS, or are we just assuming it allows SIMS data too? ↺
-
snit
sorry haven't been keeping up so might be a stupid question lole
-
Cynthia
>> So snit, I'll be modifying the ProtoXEP to remove any mentions of packs, and instead in Implementation Notes, recommend that implementations implement 0449 and use that as emoji packs if they want > that'll work for me yeah. do you think it might be an issue that it only specifies SFS, or are we just assuming it allows SIMS data too? It doesn't specify SFS only anymore ↺
-
Cynthia
It's either SFS or SIMS
-
snit
sorry, by "it" i meant XEP-0449 packs
-
Cynthia
Ah
-
Cynthia
Well I don't think it matters
-
snit
wouldn't it matter for all the same reasons the markup protoxep allows both?
-
Cynthia
I guess it would or implementations would just refuse to implement 0449
-
snit
i guess worst case scenario i can just bug the author of 0449 about making it more generic lole
-
snit
and if they don't wanna then seems like a good excuse to write my own SIMS extension to it
-
Cynthia
Submitted a PR in the XSF github
-
snit
huge wins for the custom emoji community
-
moparisthebest
> if anyone wonders, i tracked it down its chunked http encoding but http libraries/clients deal with this, how was it getting prepended to the file? ↺
-
snit
> Submitted a PR in the XSF github okay just getting around to reading it (should've done this before you submitted): * "the <emoji />" needs a capital "The" * "it MUST include one or more &xep0300; <hash /> elements to identify the specific emoji" should probably clarify that the hash obviously has to match one listed in the file metadata lole * we're doing it in the <span />? i thought we decided against that * the implementation note lists two unrelated points as a single sentence, which i find odd. i also think the point about scaling the emoji is just a given and i don't think a protocol specification needs to tell the client they can scale down a 4k image to fit it in the UI * the changelog says there're notes about bob, but i don't see any * dependencies need to be updated. we no longer depend on BoB (depending on the missing notes), and it might be good to add SIMS/SFS as a dependency maybe, and definitely XEP-0300 since we use it no matter what * abstract mentions SFS but not SIMS * might be worth clarifying use of the 'id' attribute with SFS, even if its just "id can be anything as we don't use it at all" ↺
-
Cynthia
> okay just getting around to reading it (should've done this before you submitted): > * "the <emoji />" needs a capital "The" > * "it MUST include one or more &xep0300; <hash /> elements to identify the specific emoji" should probably clarify that the hash obviously has to match one listed in the file metadata lole > * we're doing it in the <span />? i thought we decided against that > * the implementation note lists two unrelated points as a single sentence, which i find odd. i also think the point about scaling the emoji is just a given and i don't think a protocol specification needs to tell the client they can scale down a 4k image to fit it in the UI > * the changelog says there're notes about bob, but i don't see any > * dependencies need to be updated. we no longer depend on BoB (depending on the missing notes), and it might be good to add SIMS/SFS as a dependency maybe, and definitely XEP-0300 since we use it no matter what > * abstract mentions SFS but not SIMS > * might be worth clarifying use of the 'id' attribute with SFS, even if its just "id can be anything as we don't use it at all" :( ↺
-
snit
sorry luckily most of those are editorial changes lole
-
Cynthia
but singpolyma told me to put it in a span
-
snit
oh okay
-
snit
yeah like i said earlier i don't mind either way regarding spans
-
singpolyma
Marvin is the one to ask there but that's my understanding of how span should be used
-
snit
i wish 0394 was more clear about what specifically that element even does
-
Cynthia
> sorry luckily most of those are editorial changes lole is it good enough noooooowww ↺
-
snit
> is it good enough noooooowww i have devastating news ↺
-
snit
you did the entity for XEP-0385 incorrectly in the abstract, so now the file isn't going to validate
-
snit
but other than that yes that should be good
-
snit
also out of curiosity what was the BoB note going to be?
-
Cynthia
> also out of curiosity what was the BoB note going to be? The implementation notes you put ↺
-
Cynthia
What I meant by "BoB notes" were the stuff you put about that
-
Cynthia
> you did the entity for XEP-0385 incorrectly in the abstract, so now the file isn't going to validate FUUUUCCCCKK ↺
-
snit
> What I meant by "BoB notes" were the stuff you put about that oic ↺
-
Cynthia
What do I do?
-
Cynthia
If its not gonna validate, are they gonna close the PR immediately?
-
snit
> FUUUUCCCCKK for future reference if you run `xsltproc xep.xsl protoxep.xml` in the base of the xsf/xeps repository and it'll convert it to html for you but more importantly it'll tell you if its broken ↺
-
snit
> If its not gonna validate, are they gonna close the PR immediately? probably not they'll just ask you to fix it or do it themselves ↺
-
snit
you just need to add the leading 0 to the number
-
singpolyma
>> FUUUUCCCCKK > for future reference if you run `xsltproc xep.xsl protoxep.xml` in the base of the xsf/xeps repository and it'll convert it to html for you but more importantly it'll tell you if its broken I think if you run the makefile it does this for you also ↺
-
snit
WHAT
-
snit
holy moly i didn't even realise there was a makefile
-
snit
this should probably be added to XEP-0143 because right now it just suggests running xsltproc manually
-
lissine
RE SFS vs SIMS: from my understanding, the biggest advantage of SFS from a user perspective is that you can send multiple files in the same message, while being backwards compatible with clients that implement only oob
-
cal0pteryx
snit: https://github.com/xsf/xeps/blob/master/docs/REPOSITORY.md
-
alexnevashno
О
-
Cynthia
snit: what did you do after you submitted the protoXEP?
-
singpolyma
> RE SFS vs SIMS: from my understanding, the biggest advantage of SFS from a user perspective is that you can send multiple files in the same message, while being backwards compatible with clients that implement only oob You mean the attach-later thing? Technically you could do that with sims but it's true SFS added that more recently as an idea so if people want to go with that style it could be considered another difference ↺
-
snit
> snit: https://github.com/xsf/xeps/blob/master/docs/REPOSITORY.md oh nice lol. both readmes mention that directory being for the editor so i promptly ignored it 💀 ↺
-
cal0pteryx
Yep, same thing here. Should be linked from the main readme
-
snit
> snit: what did you do after you submitted the protoXEP? i just waited a week or two for it to get merged (which seems to be on the same day as the council meeting where voting will start) and then once the voting starts you get to battle the standards@ readme 😈 ↺
-
snit
usually for two weeks or if you're special like me 😎 you'll get three
-
Cynthia
>> snit: what did you do after you submitted the protoXEP? > i just waited a week or two for it to get merged (which seems to be on the same day as the council meeting where voting will start) and then once the voting starts you get to battle the standards@ readme 😈 Oh so I have to wait :( ↺