XSF Discussion - 2018-11-23

  1. lskdjf has left
  2. lskdjf has left
  3. j.r has joined
  4. j.r has joined
  5. jjrh has left
  6. SamWhited has left
  7. Alex has left
  8. Alex has joined
  9. Alex has left
  10. efrit has joined
  11. UsL has left
  12. UsL has joined
  13. jjrh has left
  14. vanitasvitae has left
  15. vanitasvitae has joined
  16. vanitasvitae has left
  17. vanitasvitae has joined
  18. j.r has joined
  19. efrit has left
  20. efrit has joined
  21. j.r has joined
  22. lskdjf has joined
  23. Zash has left
  24. SamWhited has left
  25. j.r has joined
  26. j.r has joined
  27. alacer has joined
  28. MattJ has joined
  29. alacer has left
  30. j.r has left
  31. j.r has joined
  32. guusdk has left
  33. guusdk has left
  34. guusdk has joined
  35. efrit has left
  36. Andrew Nenakhov has left
  37. j.r has joined
  38. j.r has joined
  39. vanitasvitae has left
  40. vanitasvitae has joined
  41. moparisthebest has left
  42. moparisthebest has joined
  43. j.r has joined
  44. j.r has joined
  45. moparisthebest has left
  46. moparisthebest has joined
  47. SamWhited has joined
  48. Nekit has joined
  49. krauq has left
  50. krauq has joined
  51. 404.city has joined
  52. krauq has left
  53. j.r has joined
  54. l has left
  55. j.r has joined
  56. j.r has left
  57. j.r has joined
  58. lskdjf has joined
  59. vinx55 has joined
  60. krauq has joined
  61. mimi89999 has left
  62. Str4tocaster has joined
  63. lnj has joined
  64. lorddavidiii has joined
  65. lorddavidiii has left
  66. lorddavidiii has joined
  67. vinx55 has left
  68. andy has joined
  69. lorddavidiii has left
  70. waqas has joined
  71. lorddavidiii has joined
  72. Yagiza has joined
  73. lnj has left
  74. lorddavidiii has left
  75. lorddavidiii has joined
  76. lorddavidiii has left
  77. lorddavidiii has joined
  78. ta has joined
  79. j.r has joined
  80. lorddavidiii has left
  81. lorddavidiii has joined
  82. j.r has joined
  83. guusdk has left
  84. guusdk has joined
  85. Yagiza has left
  86. lorddavidiii has left
  87. lorddavidiii has joined
  88. j.r has joined
  89. waqas has left
  90. waqas has joined
  91. Alex has joined
  92. Alex has left
  93. alacer has joined
  94. lorddavidiii has left
  95. guusdk has left
  96. moparisthebest has joined
  97. blabla has left
  98. blabla has joined
  99. lorddavidiii has joined
  100. alacer has left
  101. lorddavidiii has left
  102. j.r has joined
  103. Alex has joined
  104. lorddavidiii has joined
  105. guusdk has left
  106. guusdk has joined
  107. lskdjf has joined
  108. Alex has left
  109. lorddavidiii has left
  110. lorddavidiii has joined
  111. Tobias has joined
  112. Steve Kille has left
  113. Ge0rG is it illegal to send a presence update to multiple joined MUCs using the same szanza id?
  114. Str4tocaster has left
  115. Str4tocaster has joined
  116. Str4tocaster has left
  117. Str4tocaster has joined
  118. jonas’ maybe
  119. jonas’ It is up to the originating entity whether the value of the 'id' attribute is unique only within its current stream or unique globally.
  120. jonas’ you’re fulfilling neither of those .. requirements .. in that case
  121. ralphm But treating ids as unique in its own is bound to give you grief, so better take the addressing into account.
  122. Ge0rG oh god who wrote that code? `if (packetID != null ? !packetID.equals(packet.packetID) : packet.packetID != null) {`
  123. ralphm Oops
  124. Steve Kille has joined
  125. lorddavidiii has left
  126. Ge0rG has left
  127. lorddavidiii has joined
  128. Ge0rG So I was just sending the same presence packet to multiple @to MUCs, to my own participant JID, but it turns out only to work randomly. And from the logs it seems to have uncovered another unrelated bug.
  129. Ge0rG Oh my. You can't send-change-send the same Packet object in smack3.
  130. ralphm I think there's an assumption that clients don't repeat stanza ids on outbound traffic, but can't find the reference. As a recipient, you probably want to associate with the sender and recipient address. I'm pretty sure there are a lot of exploitable/buggy implementations.
  131. ralphm *especially* with MUC
  132. Ge0rG the problem is that I give smack3 a reference to the Packet object, not a copy. So by changing the JID, all of the enqueued references are sent to the same JID
  133. ralphm Haha
  134. Ge0rG which explains why the MUC status update happens randomly in a subset of MUCs
  135. ralphm That's a bad idea to try anyway
  136. Ge0rG because race conditions between enqueue and send thread.
  137. Ge0rG flow: does smack4 create a local copy of a Packet that you pass to sendPacket()?
  138. ralphm Yeah, once you send a stanza, don't touch it. I'm many libraries and languages.
  139. ralphm In
  140. Ge0rG See, I was just trying to be smart and to re-use resources.
  141. Ge0rG also, should I set the same priority for MUCs as for my normal presence, or just keep it at 0?
  142. ta has joined
  143. jonas’ aioxmpp would behave the same
  144. Ge0rG the nicest thing is, when I was debugging the user report, single-stepping through the code made the bug vanish.
  145. jonas’ but it also has a convenient way to duplicate a stanza, so...
  146. jonas’ oh, a heisenbug
  147. ralphm No, presence to MUC is directed and you can do whatever
  148. Ge0rG And I was short of telling the user they are crazy. After they provided logs, I got suspicious, because the 0198 logger told me the packet is not being counted, which should never happen after <enable/>
  149. flow has left
  150. flow has joined
  151. flow Ge0rG, no, that wouldn't be sensible, as you had to pay the copy operation for every sendStanza() whereas I'd assume only a minority calls would benefit from it
  152. flow but Presence has a copy constructor
  153. flow has left
  154. flow has joined
  155. Ge0rG flow: not in smack3 ;)
  156. flow yeah, I can't really comment on five year old code
  157. Ge0rG flow: it might be a good idea then to add a @warning to the docs, telling to never submit the same Packet twice.
  158. Ge0rG C++ has some sophisticated ownership management cruft around that. I don't think there is any way to enforce that in Java though
  159. flow I'm not sure if it justifies a warning since it is common for sink like functions that you hand over ownership of the provided arguments, but a note to the javadoc sure can't hurt
  160. Ge0rG it's not going to prevent people from doing what I did, leading to hard to debug issues. But after they realize what they did wrong, they'll see the message in the docs and feel even more ashamed.
  161. jonas’ hah
  162. flow patches welcome ;)
  163. Ge0rG I had to look up the semantics of Queue.contains() and single-step through Packet.equals() to be enlighted
  164. flow has left
  165. flow has joined
  166. marc has joined
  167. marc has left
  168. marc has joined
  169. goffi has joined
  170. 404.city has left
  171. lumi has joined
  172. APach has left
  173. APach has left
  174. APach has joined
  175. APach has left
  176. APach has joined
  177. ralphm has joined
  178. Andrew Nenakhov has joined
  179. APach has left
  180. Zash has joined
  181. guusdk has left
  182. APach has left
  183. APach has joined
  184. guusdk has left
  185. vanitasvitae has left
  186. vanitasvitae has joined
  187. genofire has left
  188. mrdoctorwho has left
  189. mrdoctorwho has joined
  190. Seve Hey guys, I couldn't attend the meeting yesterday unfortunately, but congratulations to everyone and thank you very much Alex :)
  191. jonas’ Seve, congratulations to you, too :)
  192. guusdk has joined
  193. Ge0rG and congratulations to jonas’ as well!
  194. jonas’ thanks, but didn’t we have that yesterday or did I miss something? ;-)
  195. Ge0rG jonas’: I think I didn't congratulate you specifically.
  196. jonas’ ah, well
  197. guusdk has left
  198. Seve sends happy stanzas for everyone.
  199. Ge0rG now wonders what the XML looks like for that
  200. Zash User Mood?
  201. Zash `<happy xmlns='http://jabber.org/protocol/mood'/>`
  202. jonas’ <x xmlns="jabber:x:oob"><url>https://www.youtube.com/watch?v=ZbZSe6N_BXs</url></x>?
  203. Zash Lol ❌
  204. Ge0rG jonas’: I'm disappointed in your taste of music.
  205. APach has joined
  206. Ge0rG (I also kind of had expected https://www.youtube.com/watch?v=DLzxrzFCyOs)
  207. APach has left
  208. jonas’ Ge0rG, who says that this is my taste of music?
  209. APach has left
  210. Guus has left
  211. Ge0rG jonas’: I considered it would be too meta if you implied that that was Seve's music taste.
  212. jonas’ no, I don’t know his music taste :)
  213. McKael has left
  214. Seve I like human music
  215. Guus has joined
  216. Ge0rG as opposed to computer-generated music?
  217. Ge0rG what about music written by humans and performed by computers? (the 386dx project comes to mind)
  218. edhelas has left
  219. Yagiza has joined
  220. Seve It was a reference to a show called Rick and Morty :D https://www.youtube.com/watch?v=S1jWdeRKvvk
  221. Alex has joined
  222. vanitasvitae has left
  223. vanitasvitae has joined
  224. ThibG has joined
  225. ThibG has joined
  226. Andrew Nenakhov has left
  227. Andrew Nenakhov has left
  228. Andrew Nenakhov has left
  229. genofire has joined
  230. lovetox has joined
  231. igoose has joined
  232. Alex has left
  233. Andrew Nenakhov has left
  234. Zash has left
  235. Andrew Nenakhov has left
  236. Str4tocaster has left
  237. Str4tocaster has joined
  238. Str4tocaster has left
  239. Str4tocaster has joined
  240. vaulor has joined
  241. guusdk has left
  242. guusdk has joined
  243. Guus has left
  244. Guus has joined
  245. Guus has left
  246. Syndace has joined
  247. Guus has joined
  248. guusdk has left
  249. guusdk has joined
  250. vaulor has joined
  251. goffi has joined
  252. Guus has left
  253. Guus has joined
  254. Guus has left
  255. APach has left
  256. Str4tocaster has left
  257. Str4tocaster has joined
  258. j.r has left
  259. lumi has joined
  260. lovetox has left
  261. 404.city has joined
  262. edhelas has left
  263. j.r has joined
  264. goffi has joined
  265. ThibG has joined
  266. ThibG has joined
  267. waqas has left
  268. j.r has joined
  269. Str4tocaster has left
  270. Str4tocaster has joined
  271. goffi has joined
  272. Str4tocaster has left
  273. daniel has left
  274. Str4tocaster has joined
  275. guusdk has left
  276. guusdk has joined
  277. Guus has joined
  278. Str4tocaster has left
  279. 404.city has left
  280. Str4tocaster has joined
  281. Str4tocaster has left
  282. Str4tocaster has joined
  283. Andrew Nenakhov has left
  284. Str4tocaster has left
  285. Andrew Nenakhov has left
  286. matlag has left
  287. Zash has left
  288. Andrew Nenakhov has left
  289. nyco has left
  290. daniel has left
  291. lskdjf has joined
  292. Guus has left
  293. Guus has joined
  294. lovetox has joined
  295. Guus has left
  296. j.r has joined
  297. Guus has joined
  298. 404.city has left
  299. andy has left
  300. ThibG has joined
  301. ThibG has joined
  302. Zash has left
  303. lorddavidiii has left
  304. moparisthebest has joined
  305. flow
  306. matlag has left
  307. j.r has joined
  308. Zash has joined
  309. l has left
  310. dos has joined
  311. Guus has left
  312. Guus has joined
  313. Zash has left
  314. Andrew Nenakhov has left
  315. igoose has joined
  316. Zash has left
  317. matlag has left
  318. !xsf_martin has joined
  319. !xsf_martin has left
  320. 404.city has joined
  321. !xsf_martin has joined
  322. !xsf_martin has left
  323. genofire has left
  324. Zash has left
  325. Zash has joined
  326. nyco has left
  327. goffi has joined
  328. jonas’ empty message is empty
  329. genofire has joined
  330. ralphm has left
  331. l has joined
  332. ThibG has joined
  333. ThibG has joined
  334. tux has left
  335. tux has joined
  336. vanitasvitae has left
  337. vanitasvitae has joined
  338. lorddavidiii has joined
  339. rion has joined
  340. alacer has joined
  341. alacer has left
  342. alacer has joined
  343. lskdjf has joined
  344. ta has left
  345. guusdk has left
  346. guusdk has joined
  347. Guus has left
  348. l has joined
  349. guusdk has left
  350. mightyBroccoli has left
  351. mightyBroccoli has joined
  352. alacer has left
  353. l has joined
  354. alacer has joined
  355. alacer has left
  356. alacer has joined
  357. Ge0rG has left
  358. APach has left
  359. alacer has left
  360. lovetox has left
  361. lnj has joined
  362. dos has left
  363. dos has joined
  364. 404.city has left
  365. labdsf has left
  366. genofire has left
  367. UsL has left
  368. UsL has joined
  369. alacer has joined
  370. alacer has left
  371. alacer has joined
  372. guusdk has left
  373. vanitasvitae has left
  374. vanitasvitae has joined
  375. Zash has left
  376. Yagiza has left
  377. labdsf has joined
  378. Zash has joined
  379. nyco has left
  380. nyco has left
  381. alacer has left
  382. lskdjf has joined
  383. Steve Kille has left
  384. Steve Kille has left
  385. l has left
  386. valo has joined
  387. l has joined
  388. Steve Kille has joined
  389. Zash has left
  390. Andrew Nenakhov has joined
  391. j.r has joined
  392. Steve Kille has left
  393. daniel has left
  394. Yagiza has joined
  395. Zash has joined
  396. igoose has joined
  397. daniel has left
  398. daniel has left
  399. ThibG has left
  400. ThibG has joined
  401. ThibG has left
  402. ThibG has joined
  403. lskdjf has joined
  404. daniel has left
  405. marc has left
  406. rainslide has joined
  407. rainslide has left
  408. lskdjf has joined
  409. rainslide has left
  410. valo has joined
  411. lskdjf has left
  412. Zash has left
  413. guusdk has left
  414. l has left
  415. guusdk has joined
  416. rainslide has left
  417. rainslide has left
  418. lorddavidiii has left
  419. lskdjf has joined
  420. Zash has left
  421. igoose has joined
  422. Zash has left
  423. Zash has left
  424. lorddavidiii has joined
  425. ThibG has left
  426. ThibG has joined
  427. Zash has left
  428. Zash has left
  429. Zash has left
  430. guusdk has left
  431. guusdk has joined
  432. waqas has joined
  433. moparisthebest has joined
  434. marc has joined
  435. moparisthebest has joined
  436. vaulor has left
  437. vaulor has joined
  438. igoose has joined
  439. vanitasvitae has left
  440. labdsf has left
  441. jjrh has left
  442. genofire has joined
  443. guusdk has left
  444. guusdk has joined
  445. labdsf has joined
  446. guusdk has left
  447. marc has left
  448. Zash has left
  449. igoose has joined
  450. j.r has left
  451. j.r has joined
  452. mimi89999 has left
  453. guusdk has left
  454. guusdk has joined
  455. guusdk has left
  456. guusdk has joined
  457. lorddavidiii has left
  458. lorddavidiii has joined
  459. jjrh has left
  460. Seve has left
  461. dos has joined
  462. dos has joined
  463. tux has left
  464. SamWhited has left
  465. valo has joined
  466. alexde has joined
  467. ta has left
  468. ta has left
  469. 404.city has joined
  470. goffi has joined
  471. vanitasvitae has left
  472. 404.city has left
  473. Holger has left
  474. daniel has left
  475. marc has joined
  476. l has left
  477. l has joined
  478. moparisthebest has left
  479. moparisthebest has joined
  480. daniel has left
  481. matlag has left
  482. lorddavidiii has left
  483. lorddavidiii has joined
  484. l has joined
  485. Maranda has joined
  486. Yagiza has left
  487. marc has left
  488. l has joined
  489. vaulor has left
  490. genofire has left
  491. genofire has joined
  492. alexde has left
  493. rion has left
  494. Zash has left
  495. efrit has joined
  496. moparisthebest has joined
  497. moparisthebest has joined
  498. Zash has left
  499. matlag has left
  500. efrit has left
  501. efrit has joined
  502. l has joined
  503. moparisthebest has joined
  504. MattJ has joined
  505. moparisthebest has joined
  506. valo has joined
  507. lnj has left
  508. l has joined
  509. genofire has left
  510. genofire has joined
  511. matlag has left
  512. vanitasvitae has left
  513. vanitasvitae has joined
  514. matlag has left
  515. genofire has left
  516. genofire has joined