-
Alex
is it a concern that Python 3.3 builds are failing on xmpp.org CI?
-
jonas’
yes
-
jonas’
they are the syntax check for the JSON files
-
jonas’
I recently learnt that one can put descriptive labels on travis jobs
-
jonas’
we should do that ;)
-
jonas’
Alex, so check the build logs, they (should) explain what’s wrong
-
jonas’
if it’s not clear to you, send me a link to the failed build and I’ll look into it
-
ralphm
Just commented on the ticket.
-
ralphm
Apparently, Travis can not / no longer download 3.3.
-
ralphm
Which is also ancient.
-
ralphm
(2012)
-
Alex
jonas’: its this PR: https://github.com/xsf/xmpp.org/pull/604
-
ralphm
Maybe we should run this job with 3.7 instead.
-
jonas’
oh dear
-
jonas’
yeah
-
jonas’
or 3.6 or something
-
jonas’
3.7 was tricky with travis, too
-
ralphm
Alex: since this change doesn't actually touch the files being linted with Python 3, I think you can just merge.
-
jonas’
ralphm, sure? I think the member list is linted
-
ralphm
jonas’: really? 3.7.0 was released over a year ago
-
jonas’
ah it’s not
-
jonas’
ralphm, yes, but something about their infrastructure
-
jonas’
you need to change more than just the python version
-
ralphm
Well, it didn't help that they canned a bunch of people after the acquisition.
-
ralphm
jonas’: shall I have a go?
-
ralphm
jonas’: meanwhile, you agree Alex can merge?
-
jonas’
yes, go for a merge
-
linkmauve
When I did https://github.com/xsf/xmpp.org/pull/595 I didn’t encounter any visible issue, all tests passed.
-
Alex
usually I do not merge my own PRs, but happy to do so ;-)
-
jonas’
done
-
Alex
(Y)
-
ralphm
linkmauve: could be it is not failing all the time
-
jonas’
https://github.com/xsf/xmpp.org/pull/605
-
jonas’
let’s see how that goes
-
ralphm
jonas’: why not PR 595?
-
jonas’
because I didn’t click the link
-
ralphm
Python 3.6 was last released in December
-
jonas’
it’s obviously better
-
ralphm
yay
-
jonas’
although a smoke test that it actually still runs the tests would be good
-
jonas’
(which I’ll do in a sec)
-
ralphm
I triggered a rebuild: https://travis-ci.org/xsf/xmpp.org/builds/564874726
-
ralphm
And 3.7 succeeds
-
ralphm
Let's merge it.
-
jonas’
wait
-
jonas’
only merge it if this build fails: https://travis-ci.org/xsf/xmpp.org/jobs/578703384
-
ralphm
I assumed you would merge anyway :-D
-
ralphm
but yay, it fails