Ge0rGjubalh: there was also a heated debate, with some people claiming that your approach is the most sensible one
Ge0rGthose people lost
lorddavidiiihas joined
pep.poezio still does it that way fwiw, it's on the TODO(tm) to change it
Ge0rGjubalh: so essentially, you need to store the first message id and the last correction's message id and match on either
HolgerWelcome to XMPP!
HolgerThe obvious solution would be to introduce another ID.
j.rhas left
pep.Holger, I escape issues by not sending more than one correction to a message :-°
Holger:-)
HolgerAs an MCabber user, I appreciate that anyway.
pep.hehe
Ge0rGInfo> Plugin progress loaded
jonas’that’s akin to "ICMB armed"
jonas’that’s akin to "ICBM armed"
pep.I don't especially dislike corrections. I do dislike the social crap around it though (and around other features that fondamentally disrupt the normal flow of discussion)
jonas’I get the impression most of the things you dislike are about the social crap around it ;)
pep.Probably
Ge0rGhttps://op-co.de/tmp/progress.mp4
j.rhas joined
HolgerXMPP would be awesome if people wouldn't abuse it for communication.
pep.Holger, yeah
pep.Well.. not exactly
Ge0rG> XMPP would be awesome if people wouldn't ~ab~ use it ~for communication~.
pep.I'm still gonna have to fight people on how to use other solutions..
DanielI just store all ids
DanielAnd if any match I apply the correction
Dele Olajidehas left
DanielYolo message correction
Ge0rGDaniel: that only works if you also store all versions of the message (which is a good idea to do anyway, but not always feasible)
DanielYeah I'll keep that in mind for the 2023 rewrite
pep.I'm still curious to know if <body/> is the only thing ever that can be corrected
pep.Because that's not how I read the thing
Ge0rGpep.: anything can be corrected
pep.Right so I need to keep the entire message
debaclehas left
Ge0rGpep.: it depend
Ge0rGpep.: it depends
pep."The receiving client then treats the newly received payloads as completely replacing all payloads of the original message."
ajhas joined
pep.(which also makes it work btw with e2ee)
Ge0rGpep.: yes
Ge0rGpep.: if you only store the body, you can replace the body with whatever you extract from the correction
pep.Ge0rG, "I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo"
DanielSo if you are correcting a 184 you have to remove one checkmark and apply it somewhere else
Ge0rGDaniel: yeah
Dele Olajidehas joined
Ge0rGexcept, if somebody LMCs a 0184, you are allowed to do horrible things to them
pep.Send them a LMC of 0184 in return?
Dele Olajidehas left
DanielI just correct the same 333 display marker over and over. That's how I move it down
Dele Olajidehas joined
jubalhDaniel: yes I guessed that Conversations does something different. Because my tests with Conversations worked even before I read that detail.
Dele Olajidehas left
Dele Olajidehas joined
pep.Daniel, jk? (just to make sure)
Danieljubalh: yes Conversations did the old thing until fairly Recently. And I want to be compatible with myself
Danielpep.: yes
DanielBut that'd be funny. Because that's how you could also move it up
DanielAnd unread things
Ge0rGDaniel: that's an awesome idea. That way, mamfc will only give you the latest Marker!
pep.interesting
pep.Daniel, actually I like that :x
pep.Not especially the LMC hack, but the possibility to move it up again
pep."Wait no I wasn't done read here actually"
adiaholichas left
adiaholichas joined
pep.(Of course I still don't want to send that to the recipient, only to myself, but most people probably don't care :))
ajhas left
pep.Maybe the new Inbox answers this
pep.or not
Marandahas left
Marandahas joined
jubalhDaniel: whats the old thing?
DanielUsing the last ID
DanielNot the original id
jubalhah
jubalhWell. I would have much preferred that way
jubalhStill don't see an advantage of the "new way"
pep.I don't either
DanielWell think of it as fastening
DanielYou need to store all the corrections alongside the original
romeohas left
romeohas joined
jubalhSo far I store only the message/last correction
pep.So it's technically possible to remove a correction right? Or would be, with fastening
XSF Discussion - 2020-02-12