XSF Discussion - 2020-12-01

  1. emus has left
  2. Wojtek has left
  3. Andrzej has left
  4. Andrzej has joined
  5. govanify has left
  6. govanify has joined
  7. Lance has left
  8. alameyo has left
  9. Andrzej has left
  10. alex-a-soto has left
  11. alex-a-soto has joined
  12. lskdjf has left
  13. krauq has left
  14. krauq has joined
  15. chronosx88 has left
  16. Wojtek has joined
  17. Wojtek has left
  18. deuill has joined
  19. deuill has left
  20. stpeter has joined
  21. stpeter has left
  22. LNJ has left
  23. dwd has left
  24. Arne has left
  25. Arne has joined
  26. krauq has left
  27. alameyo has joined
  28. krauq has joined
  29. wladmis has left
  30. adiaholic has left
  31. adiaholic has joined
  32. Andrzej has joined
  33. Zash has left
  34. Zash has joined
  35. Lance has joined
  36. adiaholic has left
  37. adiaholic has joined
  38. Andrzej has left
  39. LNJ has joined
  40. Lance has left
  41. Lance has joined
  42. Lance has left
  43. chronosx88 has joined
  44. stpeter has joined
  45. stpeter has left
  46. stpeter has joined
  47. stpeter has left
  48. govanify has left
  49. govanify has joined
  50. alameyo has left
  51. murabito has joined
  52. adiaholic has left
  53. adiaholic has joined
  54. alameyo has joined
  55. krauq has left
  56. krauq has joined
  57. murabito has left
  58. murabito has joined
  59. stpeter has joined
  60. stpeter has left
  61. Andrzej has joined
  62. NosoyHacker404 has left
  63. NosoyHacker404 has joined
  64. govanify has left
  65. govanify has joined
  66. Andrzej has left
  67. murabito has left
  68. Yagiza has joined
  69. govanify has left
  70. govanify has joined
  71. APach has left
  72. APach has joined
  73. krauq has left
  74. krauq has joined
  75. larma has left
  76. Mikaela has joined
  77. larma has joined
  78. andy has joined
  79. Tobias has joined
  80. lorddavidiii has joined
  81. wladmis has joined
  82. govanify has left
  83. govanify has joined
  84. chronosx88 has left
  85. chronosx88 has joined
  86. Andrzej has joined
  87. krauq has left
  88. krauq has joined
  89. stpeter has joined
  90. stpeter has left
  91. Andrzej has left
  92. paul has joined
  93. chronosx88 has left
  94. chronosx88 has joined
  95. dwd has joined
  96. govanify has left
  97. govanify has joined
  98. jcbrand has joined
  99. krauq has left
  100. krauq has joined
  101. Tim has joined
  102. Tim has left
  103. david has left
  104. david has joined
  105. david has left
  106. david has joined
  107. wladmis has left
  108. lorddavidiii has left
  109. neshtaxmpp has left
  110. neshtaxmpp has joined
  111. lorddavidiii has joined
  112. goffi has joined
  113. govanify has left
  114. govanify has joined
  115. floretta has left
  116. Andrzej has joined
  117. lorddavidiii has left
  118. lorddavidiii has joined
  119. alex-a-soto has left
  120. alex-a-soto has joined
  121. adiaholic has left
  122. adiaholic has joined
  123. emus has joined
  124. matkor has joined
  125. eevvoor has joined
  126. Andrzej has left
  127. debacle has joined
  128. stpeter has joined
  129. stpeter has left
  130. LNJ has left
  131. chronosx88 has left
  132. chronosx88 has joined
  133. intosi has joined
  134. arc has left
  135. arc has joined
  136. adiaholic has left
  137. adiaholic has joined
  138. Kev has joined
  139. chronosx88 has left
  140. chronosx88 has joined
  141. lskdjf has joined
  142. lskdjf has left
  143. lskdjf has joined
  144. chronosx88 has left
  145. chronosx88 has joined
  146. debacle has left
  147. inky has left
  148. Andrzej has joined
  149. stpeter has joined
  150. stpeter has left
  151. adiaholic has left
  152. adiaholic has joined
  153. LNJ has joined
  154. Andrzej has left
  155. adiaholic has left
  156. adiaholic has joined
  157. Kev has left
  158. Kev has joined
  159. Kev has left
  160. Kev has joined
  161. lorddavidiii has left
  162. Andrzej has joined
  163. Kev has left
  164. Kev has joined
  165. Kev has left
  166. lorddavidiii has joined
  167. Kev has joined
  168. LNJ has left
  169. Adi has left
  170. raghavgururajan has left
  171. alex-a-soto has left
  172. alex-a-soto has joined
  173. lorddavidiii has left
  174. Adi has joined
  175. adiaholic has left
  176. adiaholic has joined
  177. Steve Kille has left
  178. Steve Kille has joined
  179. stpeter has joined
  180. stpeter has left
  181. lorddavidiii has joined
  182. wladmis has joined
  183. LNJ has joined
  184. floretta has joined
  185. adiaholic has left
  186. adiaholic has joined
  187. chronosx88 has left
  188. chronosx88 has joined
  189. chronosx88 has left
  190. chronosx88 has joined
  191. lorddavidiii has left
  192. peetah has left
  193. peetah has joined
  194. lorddavidiii has joined
  195. chronosx88 has left
  196. chronosx88 has joined
  197. chronosx88 has left
  198. chronosx88 has joined
  199. arc has left
  200. arc has joined
  201. chronosx88 has left
  202. chronosx88 has joined
  203. chronosx88 has left
  204. chronosx88 has joined
  205. wladmis has left
  206. arc has left
  207. arc has joined
  208. arc has left
  209. arc has joined
  210. wladmis has joined
  211. alex-a-soto has left
  212. alex-a-soto has joined
  213. debacle has joined
  214. stpeter has joined
  215. stpeter has left
  216. adiaholic has left
  217. adiaholic has joined
  218. Andrzej has left
  219. Andrzej has joined
  220. Syndace has left
  221. xecks has left
  222. Syndace has joined
  223. xecks has joined
  224. wladmis has left
  225. wladmis has joined
  226. Andrzej has left
  227. adiaholic has left
  228. intosi has left
  229. j.r has left
  230. j.r has joined
  231. wladmis has left
  232. wladmis has joined
  233. Andrzej has joined
  234. Andrzej has left
  235. intosi has joined
  236. Andrzej has joined
  237. adiaholic has joined
  238. stpeter has joined
  239. stpeter has left
  240. floretta has left
  241. intosi has left
  242. wladmis has left
  243. intosi has joined
  244. chronosx88 has left
  245. chronosx88 has joined
  246. wladmis has joined
  247. floretta has joined
  248. adiaholic has left
  249. adiaholic has joined
  250. adiaholic has left
  251. adiaholic has joined
  252. Andrzej has left
  253. Arne has left
  254. Andrzej has joined
  255. Arne has joined
  256. Arne has left
  257. Arne has joined
  258. jonas’ dwd, spreadsheet of doom?
  259. lorddavidiii has left
  260. Andrzej has left
  261. Andrzej has joined
  262. Wojtek has joined
  263. lorddavidiii has joined
  264. lskdjf has left
  265. lskdjf has joined
  266. lskdjf has left
  267. lskdjf has joined
  268. Steve Kille has left
  269. lskdjf has left
  270. Steve Kille has joined
  271. stpeter has joined
  272. stpeter has left
  273. lskdjf has joined
  274. NosoyHacker404 has left
  275. NosoyHacker404 has joined
  276. lorddavidiii has left
  277. Arne has left
  278. Arne has joined
  279. dwd jonas’, https://docs.google.com/spreadsheets/d/1-IBY4NhXbdZ_TqCCZkXrMgqq63yytaxXqJKhh47J1vI/edit?usp=sharing - but poke it about to see if I've cleared the old data off it correctly first. I think I have, but ENOQA.
  280. chronosx88 has left
  281. chronosx88 has joined
  282. krauq has left
  283. krauq has joined
  284. NosoyHacker404 has left
  285. chronosx88 has left
  286. chronosx88 has joined
  287. intosi has left
  288. jonas’ dwd, I need your approval for +w, I sent a request
  289. alex-a-soto has left
  290. alex-a-soto has joined
  291. intosi has joined
  292. chronosx88 has left
  293. chronosx88 has joined
  294. chronosx88 has left
  295. chronosx88 has joined
  296. lorddavidiii has joined
  297. jonas’ mathieui> whoops I forgot to look at pending PRs before submitting my MIX patches, but it looks like there’s no overlap at least with which of the current PRs do you see a conflict?
  298. mathieui jonas’, no conflict, but I saw a few MIX-related ones after looking
  299. jonas’ dwd, nevermind, I forked it
  300. jonas’ mathieui, which ones?
  301. dwd jonas’, Oh, sorry, didn't think of that.
  302. mathieui jonas’, only #856 actually
  303. jonas’ right, that one’s not gonna happen soon anyway
  304. mathieui yup
  305. intosi has left
  306. mathieui there are deeper changes in other ones that I didn’t want to get into, e.g. reusing 0424 in 0407 section 4 instead of providing an ad-hoc mechanism+namespace
  307. jonas’ Ge0rG, can you obtain approval by the author of '401 for: https://gitlab.com/xsf/xeps/-/merge_requests/33
  308. jonas’ cc @ marc
  309. eta has left
  310. Maranda has left
  311. eta has joined
  312. Maranda has joined
  313. neshtaxmpp has left
  314. peetah has left
  315. peetah has joined
  316. lovetox has joined
  317. intosi has joined
  318. marc jonas’: okay for me if that's the MR Ge0rG was talking about last time
  319. jonas’ marc, please check if it really is that PR :)
  320. marc jonas’: yep, later. I'm on mobile atm
  321. jonas’ marc, thank you
  322. chronosx88 has left
  323. chronosx88 has joined
  324. intosi has left
  325. Lance has joined
  326. Yagiza has left
  327. vanitasvitae has left
  328. vanitasvitae has joined
  329. alex-a-soto has left
  330. alex-a-soto has joined
  331. floretta has left
  332. peetah has left
  333. peetah has joined
  334. lskdjf has left
  335. lskdjf has joined
  336. lorddavidiii has left
  337. intosi has joined
  338. Ge0rG it's the one splitting out IBR with token from 0401. I'm not so sure any more about the title, maybe I overdid it a bit
  339. floretta has joined
  340. lskdjf has left
  341. lskdjf has joined
  342. lskdjf has left
  343. lskdjf has joined
  344. lovetox has left
  345. lskdjf has left
  346. lskdjf has joined
  347. lskdjf has left
  348. lskdjf has joined
  349. adiaholic has left
  350. adiaholic has joined
  351. lskdjf has left
  352. lskdjf has joined
  353. intosi has left
  354. lskdjf has left
  355. lskdjf has joined
  356. david has left
  357. david has joined
  358. lorddavidiii has joined
  359. david has left
  360. david has joined
  361. Zash Re https://github.com/xsf/xeps/pull/1008 Does anyone actually enforce or even handle that?
  362. SamWhited I do in my implementation (just by virtue of using a uint16 which in Go wraps around if you overflow it)
  363. SamWhited I can't imagine it's likely to be something that's hit often (or ever) though.
  364. Zash Yeah, it goes into "don't use IBB for files that large" territory
  365. Zash Given a maximum block size of 65535 that's 4 GB. So, plz don't.
  366. intosi has joined
  367. SamWhited I did look around and found several other implementations that explicitly handled it (Smack is the only one I remember looking at now though, but I think there were some of the python ones too). They used uint16
  368. Zash I just looked at two and saw no trace of any overflow handling
  369. neshtaxmpp has joined
  370. Zash this one seems to do stuff tho
  371. moparisthebest https://i.imgflip.com/4oiu0k.jpg
  372. SamWhited yah, maybe it wasn't Smack, I don't see it now
  373. mathieui it is wrapped around in slixmpp afaik
  374. SamWhited ah no, here it is: https://github.com/igniterealtime/Smack/blob/master/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java#L759
  375. focus121 has left
  376. focus121 has joined
  377. Zash Is that off-by-one?
  378. SamWhited And here it is for aioxmpp: https://github.com/horazont/aioxmpp/blob/devel/aioxmpp/ibb/service.py#L195-L196
  379. SamWhited Yah, that looks off by 1 to me
  380. Zash Haven't found anything in nbxmpp and Swiften tho
  381. Zash Nobody so far seems to have accidentally read it as a the positive subset of a signed integer, which I think is a thing somewhere else.
  382. lskdjf has left
  383. lskdjf has joined
  384. stpeter has joined
  385. stpeter has left
  386. lskdjf has left
  387. lskdjf has joined
  388. intosi has left
  389. lskdjf has left
  390. lskdjf has joined
  391. flow Zash, good catch
  392. Zash np
  393. SamWhited Yah, good eye; this is why I never use weird ternary constructs, I would never have noticed it in that mess of symbols and what not
  394. flow I've just looked at the origin of this: it was introduced by henning in 2010
  395. flow so it's a 10 year old bug you discovered \o/
  396. Zash :D
  397. SamWhited Nice, Zash gets all the points
  398. lovetox has joined
  399. flow of course i wonder if this ever caused an troubles :) but that doesn't mean that this shouldn't get fixed
  400. SamWhited Heh, yah, I doubt it
  401. mathieui Zash, oh, slixmpp is also off by one as well I guess
  402. SamWhited FWIW, java does integer wraparound too IIRC, so that could probably just be an "unsigned short" or whatever it would be called in java land
  403. SamWhited Nice; multiple off by ones fixed today! As they say, the three hard problems in computer science are naming things and off by one errors
  404. Andrzej has left
  405. mathieui tricked by a modulo
  406. Andrzej has joined
  407. neshtaxmpp has left
  408. moparisthebest SamWhited, java doesn't have unsigned anything
  409. SamWhited oh, nevermind then. Been a while since I did any Java
  410. Andrzej has left
  411. Andrzej has joined
  412. adiaholic has left
  413. adiaholic has joined
  414. Zash SamWhited: nice chain of events you set in motion here :)
  415. SamWhited Yah that worked out nicely; I thought it was just going to clarify a typo fix, good teamwork turning it into bugfixes
  416. mathieui I just hope nobody ran into that, as it would reject stanzas with the 65535 sequence number
  417. flow SamWhited, the problem is that there is no uint16_t in java land
  418. SamWhited I can't imagine anyone actually sends multi-gig files (assuming a reasonable blocksize) and doesn't get bored and cancel or have some other hickup
  419. SamWhited But who knows
  420. mathieui The best file transport!
  421. SamWhited I'm sure one crazy person somewhere has done it
  422. mathieui Doing 4k livestreams over IBB
  423. chronosx88 has left
  424. chronosx88 has joined
  425. Zash Absolute madlad
  426. Andrzej has left
  427. Shell has joined
  428. Andrzej has joined
  429. intosi has joined
  430. SamWhited Tangentially related: has anyone ever experimented with different blocksizes to see what a good default is? I just kind of guessed that ~2k was probably a good default, but I really have no idea
  431. Zash For IBB? 🤷
  432. adiaholic has left
  433. adiaholic has joined
  434. moparisthebest somewhat related to stanza size limits I reckon
  435. Zash I imagine there's some sweet spot wrt filesystem block sizes, tcp/ip/ethernet packet sizes etc
  436. nyco has left
  437. SamWhited I assumed ethernet MUT would be smaller than TCP and would be too small to actually fit a stanza in (without drastically increasing the overhead just from the XML), but maybe wifi would be a better thing to lookup
  438. SamWhited MTU, even
  439. Zash 4k block gets you a ~5.5k message stanza, that's about half of the 10k minimum stanza size limit. should be safe, even with longer jids.
  440. Andrzej has left
  441. Andrzej has joined
  442. Zash a JID can be up to 3k in theory...
  443. SamWhited That sounds good to me, maybe I'll up mine which I think was at 2k
  444. Andrzej has left
  445. Andrzej has joined
  446. moparisthebest that would be a case of "some people get what they deserve" (re: 3k JIDs)
  447. Zash dns limits you to 255 or something for the hostpart, so more like 1023@255/1023
  448. SamWhited Could be a hostname though
  449. SamWhited No idea if there are limits there
  450. Arne has left
  451. Andrzej has left
  452. Andrzej has joined
  453. Zash A message stanza with 2x 1023@255/1023, 2x UUID and 4k IBB block turns into 12.5k
  454. Andrzej has left
  455. Andrzej has joined
  456. NosoyHacker404 has joined
  457. Zash heh, with 2k block it looks like 9.8k
  458. chronosx88 has left
  459. chronosx88 has joined
  460. lskdjf has left
  461. lskdjf has joined
  462. Zash so if you're absolutely want to stay clear of the strictest stanza size limits then 2k blocks would do.
  463. Andrzej has left
  464. Andrzej has joined
  465. SamWhited meh, if you have a 3k JID you can manually set the block size, that's definitely not a thing I'm interested in optimizing for
  466. lskdjf has left
  467. Zash Would be cool to have real network troughput stats ;)
  468. intosi has left
  469. marc jonas’, +1 for the PR from Ge0rG
  470. Arne has joined
  471. raghavgururajan has joined
  472. nyco has joined
  473. jonas’ marc: thabks
  474. jonas’ marc: thanks
  475. jonas’ Path-MTU!
  476. werdan has joined
  477. krauq has left
  478. Zash Mmmmmmm. I've observed MUC participants in loops where they request the vcard of someone, then get their connection closed because the avatar was larger than the stanza size limit
  479. Zash Much fun.
  480. krauq has joined
  481. lskdjf has joined
  482. lskdjf has left
  483. lskdjf has joined
  484. stpeter has joined
  485. stpeter has left
  486. lskdjf has left
  487. lskdjf has joined
  488. krauq has left
  489. krauq has joined
  490. moparisthebest big avatar crashes MUC's you say ? >:)
  491. jonas’ khekhekhe
  492. jonas’ fun fact: you cannot kick MUCs off the s.j.n list that way (except the one with the evil avatar) because s.j.n shuffles the list of MUCs during each scan :)
  493. jonas’ (even if it caused a longer outage of the s2s connection or killed the c2s connection in a bad way or somesuch)
  494. paul has left
  495. paul has joined
  496. Andrzej has left
  497. Zash Was there some point in advertising stanza size limits in stream-features or somesuch?
  498. lskdjf has left
  499. SamWhited That would be really nice; at the very least it would let clients show a rough max-message-size while you're typing.
  500. lorddavidiii has left
  501. intosi has joined
  502. chronosx88 has left
  503. chronosx88 has joined
  504. dwd FWIW, I assumed that stanza sizes were reasonable huge these days. Like 64k would be an absolute minimum. Didn't we say 10M in RFC 6120?
  505. Kev 10k
  506. Zash 10k
  507. Zash Prosody ships with a default of 10M by default, ejabberd with 256k for c2s and 512k for s2s IIRC
  508. Zash Dunno about others
  509. lskdjf has joined
  510. Zash Eh, default defaults ftw
  511. Guus I think Openfire does 2M.
  512. antranigv has left
  513. antranigv has joined
  514. Ge0rG So we need Path MTU Discovery! Will s2s be terminated on oversized stanzas? Is there an error sent to the originating node?
  515. dwd With bandwidth and RAM sizes these days, I'd think IBB at 10k blocksizes would be fine. That'll yield a 1ms choke on a 80Mbit link, so you could probably increase that by a factor of ten without worrying.
  516. Zash Ge0rG: yes. maybe, but probably no.
  517. lorddavidiii has joined
  518. Zash Push harder for s2s-198
  519. Ge0rG dwd: not on german mobile "broadband"
  520. waqas has joined
  521. Ge0rG Zash: won't help on stream errors
  522. Zash Why?
  523. dwd Ge0rG, So you don't want to much a PMTU discovery, you actually want a IBB blocksize negotiation.
  524. Zash You want PMTU discovery for vcards/avatars!
  525. SamWhited I think my implementation for blocksize "negotiation" was to just request the default, then cut it in half until they accept the transfer or it gets under some small minimum where we deam the XML encoding overhead is too high to justify bothering
  526. dwd Zash, But if you're on a slow link, do you even want the jumbo-avatar?
  527. Zash Why you want the multiple-choice 0084 allows
  528. Ge0rG dwd: how would you do that for the involved servers?
  529. neshtaxmpp has joined
  530. dwd Ge0rG, Hmmm, yes. But you probably want a path characteristics request, plus a stream feature for stanza limits. We talked of a path characteristic command for TLS a while back; one for stanza limits and 198 might be more useful.
  531. intosi has left
  532. Ge0rG dwd: all of the above, and a way to discover each hop on the way
  533. inky has joined
  534. Maranda has left
  535. Maranda has joined
  536. lorddavidiii has left
  537. stpeter has joined
  538. stpeter has left
  539. chronosx88 has left
  540. lskdjf has left
  541. lskdjf has joined
  542. intosi has joined
  543. Andrzej has joined
  544. eevvoor has left
  545. Andrzej has left
  546. Andrzej has joined
  547. intosi has left
  548. Andrzej has left
  549. Andrzej has joined
  550. Andrzej has left
  551. Andrzej has joined
  552. Mikaela has left
  553. Arne has left
  554. Arne has joined
  555. pasdesushi has joined
  556. Arne has left
  557. Arne has joined
  558. intosi has joined
  559. pasdesushi has left
  560. lorddavidiii has joined
  561. werdan has left
  562. wevifa has joined
  563. Wojtek has left
  564. Andrzej has left
  565. Andrzej has joined
  566. lovetox has left
  567. Arne has left
  568. neshtaxmpp has left
  569. Arne has joined
  570. neshtaxmpp has joined
  571. krauq has left
  572. krauq has joined
  573. intosi has left
  574. Tobias has left
  575. Andrzej has left
  576. lorddavidiii has left
  577. goffi has left
  578. lskdjf has left
  579. lskdjf has joined
  580. Andrzej has joined
  581. Adi has left
  582. Andrzej has left
  583. lskdjf has left
  584. Andrzej has joined
  585. antranigv has left
  586. antranigv has joined
  587. LNJ has left
  588. peetah has left
  589. Adi has joined
  590. peetah has joined
  591. Andrzej has left
  592. alameyo has left
  593. intosi has joined
  594. j.r has left
  595. intosi has left
  596. lskdjf has joined
  597. alameyo has joined
  598. Andrzej has joined
  599. Andrzej has left
  600. Andrzej has joined
  601. intosi has joined
  602. Adi has left
  603. Andrzej has left
  604. arc has left
  605. Adi has joined
  606. Kev has left
  607. andy has left
  608. intosi has left
  609. Andrzej has joined
  610. stpeter has joined
  611. stpeter has left
  612. Andrzej has left
  613. Andrzej has joined
  614. intosi has joined
  615. Andrzej has left
  616. debacle has left