XSF Discussion - 2020-12-16


  1. Alex

    anyone wants to review and merge my PR here? https://github.com/xsf/xmpp.org/pull/853

  2. Guus

    ME! ME! PICK ME!

  3. Guus

    oh

  4. Guus slaps Zash around a bit with a large trout.

  5. Zash

    Mouhahahaha

  6. Zash

    Fear me, I ruin all the fun!

  7. Guus

    But, yeah, looks good to me. Is that Unix/Linux thing a result of the linting?

  8. Guus

    Ah, yes.

  9. Guus

    I'm constantly lagging behind the Github changes, it seems 🙂

  10. Alex

    ya, linter fails and complains that UNIX is not defined in platforms

  11. Zash

    Whaaaa

  12. Guus

    Didn't council change at all?

  13. Zash

    Nope

  14. Alex

    not sure where I can find the failing travis validations

  15. Guus

    I'm happy to merge as-is, unless someone thinks it is important to pull out the platform change?

  16. Guus

    I can't see why - but I'll hold off pressing the big green button for a bit...

  17. Alex

    I only fixed it because I fell bad when PRs with failing CI are getting merged ;-)

  18. Alex

    here you can see an old CI build: https://travis-ci.org/github/xsf/xmpp.org/jobs/749881434

  19. Alex

    ``` $ if [[ $TRAVIS_PYTHON_VERSION == 3.7 ]]; then ./data/lint-list.py clients.json; fi ERROR: entry 'txmmp': undefined platforms: 'Unix' (the allowed platforms are listed in platforms.json. If you think a platform is missing add it and mention it in your Pull Request) Found 1 severe violations. Please fix them. ```

  20. Alex

    we can also add Unix to the platform.json

  21. jonas’

    let’s not lose valuable contributor time in such minor discussions

  22. jonas’

    especially since it’s neatly separated into separate commits

  23. Guus

    merged

  24. jonas’

    thanks

  25. jonas’

    ping me in a few so that I remember to pull the website

  26. Alex

    thanks

  27. Guus

    Thank you

  28. Alex

    Will update the Board section on this site hopefully tomorrow: https://xmpp.org/about/xmpp-standards-foundation.html

  29. Zash

    Why didn't it complain about adding "Unix" then???

  30. jonas’

    maybe it did and people ignored the CI?

  31. Alex

    I think so, I can merge with CI even failing. We should consider making CI not fail a requirement

  32. jonas’

    sounds like a reasonable plan

  33. Guus

    Meh. CI is a guide, not an authority

  34. jonas’

    Guus, I tend to disagree :)

  35. jonas’

    especially those checks

  36. jonas’

    I don’t have the necessary privileges to do that

  37. Alex

    this is why you can have warnings and errors in CI

  38. Zash

    CI OK'd https://github.com/xsf/xmpp.org/pull/849/commits/ffcd26776137877f0f8c2890093f372ce9a7a67f

  39. jonas’

    "nice"

  40. Guus walks away from the bikeshed

  41. Guus

    (and is kinda surprised it wasn't him causing the issue)

  42. Zash

    Hey, come back and accept responsibility!!!11!!eleventy!

  43. Alex

    Zash, on the last commit is sais "all checks failed"

  44. Guus pings jonas’ after af few.

  45. Guus pings jonas’ after a few.

  46. jonas’

    updated

  47. Ge0rG

    why is txmpp even there?

  48. Zash

    Has the build ever far even to go look like done?

  49. Guus

    I just waited a few.

  50. Guus

    Ge0rG I think there was debate in a github issue around that. I recall that not being a hill that I was going to die on, if memory serves.

  51. Ge0rG

    Guus: I remember that debate, but it lacked a conclusion

  52. Ge0rG

    so somebody pushed "merge" I suppose.

  53. Guus

    likely me?

  54. edhelas

    do you guys are aware of some XMPP clients that are requestion vcards on the service level ?

  55. edhelas

    *requesting

  56. moparisthebest

    for mucs?