-
Alex
anyone wants to review and merge my PR here? https://github.com/xsf/xmpp.org/pull/853
-
Guus
ME! ME! PICK ME!
-
Guus
oh
- Guus slaps Zash around a bit with a large trout.
-
Zash
Mouhahahaha
-
Zash
Fear me, I ruin all the fun!
-
Guus
But, yeah, looks good to me. Is that Unix/Linux thing a result of the linting?
-
Guus
Ah, yes.
-
Guus
I'm constantly lagging behind the Github changes, it seems 🙂
-
Alex
ya, linter fails and complains that UNIX is not defined in platforms
-
Zash
Whaaaa
-
Guus
Didn't council change at all?
-
Zash
Nope
-
Alex
not sure where I can find the failing travis validations
-
Guus
I'm happy to merge as-is, unless someone thinks it is important to pull out the platform change?
-
Guus
I can't see why - but I'll hold off pressing the big green button for a bit...
-
Alex
I only fixed it because I fell bad when PRs with failing CI are getting merged ;-)
-
Alex
here you can see an old CI build: https://travis-ci.org/github/xsf/xmpp.org/jobs/749881434
-
Alex
``` $ if [[ $TRAVIS_PYTHON_VERSION == 3.7 ]]; then ./data/lint-list.py clients.json; fi ERROR: entry 'txmmp': undefined platforms: 'Unix' (the allowed platforms are listed in platforms.json. If you think a platform is missing add it and mention it in your Pull Request) Found 1 severe violations. Please fix them. ```
-
Alex
we can also add Unix to the platform.json
-
jonas’
let’s not lose valuable contributor time in such minor discussions
-
jonas’
especially since it’s neatly separated into separate commits
-
Guus
merged
-
jonas’
thanks
-
jonas’
ping me in a few so that I remember to pull the website
-
Alex
thanks
-
Guus
Thank you
-
Alex
Will update the Board section on this site hopefully tomorrow: https://xmpp.org/about/xmpp-standards-foundation.html
-
Zash
Why didn't it complain about adding "Unix" then???
-
jonas’
maybe it did and people ignored the CI?
-
Alex
I think so, I can merge with CI even failing. We should consider making CI not fail a requirement
-
jonas’
sounds like a reasonable plan
-
Guus
Meh. CI is a guide, not an authority
-
jonas’
Guus, I tend to disagree :)
-
jonas’
especially those checks
-
jonas’
I don’t have the necessary privileges to do that
-
Alex
this is why you can have warnings and errors in CI
-
Zash
CI OK'd https://github.com/xsf/xmpp.org/pull/849/commits/ffcd26776137877f0f8c2890093f372ce9a7a67f
-
jonas’
"nice"
- Guus walks away from the bikeshed
-
Guus
(and is kinda surprised it wasn't him causing the issue)
-
Zash
Hey, come back and accept responsibility!!!11!!eleventy!
-
Alex
Zash, on the last commit is sais "all checks failed"
- Guus pings jonas’ after af few.
- Guus pings jonas’ after a few.
-
jonas’
updated
-
Ge0rG
why is txmpp even there?
-
Zash
Has the build ever far even to go look like done?
-
Guus
I just waited a few.
-
Guus
Ge0rG I think there was debate in a github issue around that. I recall that not being a hill that I was going to die on, if memory serves.
-
Ge0rG
Guus: I remember that debate, but it lacked a conclusion
-
Ge0rG
so somebody pushed "merge" I suppose.
-
Guus
likely me?
-
edhelas
do you guys are aware of some XMPP clients that are requestion vcards on the service level ?
-
edhelas
*requesting
-
moparisthebest
for mucs?