-
mathieui
Sam, FWIW the "easy" mitigation around caps poisoning is to have a per-jid caps cache
-
mathieui
that negates some if not most of the usefulness of caps, but at least it is safe
-
mathieui
(hence caps2 though)
-
Sam
Yah, I suspect that's what I'll have to do.
-
Sam
I should look into caps2 again; I have an old implementation lying around somewhere but haven't read it in ages. I wonder if it solved the original problem that I ran into this morning that made me have to restructure every damn thing.
-
sky
does anyone know where i can buy cc
-
moparisthebest
sky, https://smile.amazon.com/ccbeanie-Knitted-Headband-Headwrap-Earwarmer/dp/B07H42G87Q/
-
sky
I mean credit card
-
moparisthebest
then a bank probably
-
emus
Good monring morap, you ping me when you are ready, ok?
-
Link Mauve
emus, I just noticed you squash multiples commits together when accepting a PR on xmpp.org, this loses all of the commit history when not using the GitHub web UI.
-
Link Mauve
I would recommend you to either to a fast-forward rebase, or do merge commits instead.
-
Link Mauve
I personally prefer the former, but both are preferable to losing history imo.
-
flow
defintely, that said, merge commits ftw :)
-
mathieui
Also, when is the website getting rebuilt? is it weekly?
-
Zash
Manually by iteam
- mathieui pokes Zash for a rebuild
-
Zash
Am on phone, computer asleep.
-
MattJ
I can do it
-
emus
Link Mauve: But most of those PRs are small and the newsletter has a lot of minor stuff
-
emus
I dont wanna bloat the commit history
-
Link Mauve
That’s a bad reason imo, keeping the history readable by keeping separate changes separate is imo worth more than keeping the number of commits low.
-
emus
So you argue to never squash?
-
emus
moparisthebest: seen my message?
-
Link Mauve
Yes, if you aren’t pleased with a particular PR’s commits, ask the author to reorder them or something, but not squash them yourself.
-
Link Mauve
My most recent PR was correctly split in one commit adding xmpp-rs, one commit adding the Rust logo to the homepage.
-
Link Mauve
And I’ve seen other PRs with many more commits getting mashed together into something very hard to review after the fact.
-
emus
🤔 ok I will try to improve this an take a look for thid