-
goffi
Hi, I'm willing to implement XEP-0292 (VCard 4), but I don't really understand: there is a specific IQ protocol, and PEP is used only for event notifications (but not to store the vcard), and a whitelist node is used to store the card. The seems overcomplicated, why not using simply PEP? Also it seems that at least Movim is storing the card in the public PEP node, which is not what the XEP says. Prosody's https://prosody.im/doc/modules/mod_vcard4 also talks about storing in the PEP node.
-
goffi
(ping edhelas MattJ ^)
-
MattJ
goffi, it's PEP
-
MattJ
For some reason it also has a dedicated iq protocol, but you don't have to use it
-
MattJ
Everything can be done with PEP
-
Zash
IIRC the IQ protocol was meant to simplify upgrading from vcard-temp, and may have been intended to work in MUC (which it doesn't)
-
goffi
MattJ: this is not what the XEP says, https://xmpp.org/extensions/xep-0292.html#public is a specific protocol, and https://xmpp.org/extensions/xep-0292.html#sect-idm44771566970704 footnote says that the nofication should be empty and the proprietary protocol should be used instead.
-
Zash
(unless the MUC cooperates in the same way it does with vcard-temp)
-
goffi
OK I'll use PEP then, it's more logical and apparently it's what others are doing
-
goffi
the XEP has to be updated though.
-
Zash
Sadly I still haven't gotten around to fixing all the problems the XEP has.
-
goffi
I would like to propose a patch to fix it, but franly I have no extra time at all, I need to focus 100% on the AP gateway and rest of the grant I've had.
-
Zash
Like, the XEP mandates that the vcard be completely public, but a big benefit of building on PEP is the access control features possible with "extended" PEP (aka more pubsub features)
-
MattJ
https://mail.jabber.org/pipermail/standards/2019-January/035710.html
-
MattJ
^ Zash's feedback on the XEP on list
-
MattJ
The "Why dedicated iq?" question seems to have been asked a lot, but never directly answered afaict
-
MattJ
I think at the time a lot of servers and clients lacked PEP support, so it possibly made more sense to provide an alternative
-
MattJ
But that's no longer the case, so I think it's best to drop it
-
Zash
I have a vague memory of this being the conclusion of a Summit discussion loooooooooong ago.
-
Zash
to add the iq, that is, probably for the reasons MattJ mentions, and MUC support (but that doesn't Just Work, as said)
-
Zash
Bunch of TODOs I've sat on, waiting for the day I feel like turning it into proper prose: https://github.com/xsf/xeps/compare/master...Zash:xep-0292-updates
-
singpolyma
I'm pro dropping the dedicated iq, but then the xep definitely needs to say pep is allowed. I'm about to implement this soon and would have used the iq for compatibility even knowing the existing implementations happen to allow pep. But if the XEP is going to say pep is allowed then I would prefer to use that
-
singpolyma
Could a MUC cooperate for a single pep node fetch same as it does for vcard-temp? I think probably yes
-
MattJ
singpolyma, yes, Prosody does this. It's surprisingly controversial though...
-
MattJ
https://blog.prosody.im/modern-xmpp-auth/ - if any client devs are particularly interested in collaborating on XEP-0388 and 2FA support, let me know :)
-
Zash
and maybe roles and scopes and stuff?
-
MattJ
After the authentication stuff, yeah, that's next
-
singpolyma
I'm happy to help figure out Android stuff for Cheogram/Snikket Android and probably Conversations eventually
-
goffi
> I'm pro dropping the dedicated iq, but then the xep definitely needs to say pep is allowed. I'm about to implement this soon and would have used the iq for compatibility even knowing the existing implementations happen to allow pep. But if the XEP is going to say pep is allowed then I would prefer to use that I don't think that I'll implement the dedicated IQ, it feels like a lost of time.
-
singpolyma
goffi: so long as every server will end up supporting pep for it, I agree
-
lovetox
hm why are you saying the vcard iq odes not work in MUC?
-
lovetox
why would it not work ..
-
Zash
It depends on the existence of the same hack that exists for vcard-temp
-
Zash
So, just adding an iq by itself does nothing.
-
lovetox
hm i see i dont implement the IQ as well
-
lovetox
im simply make a pubsub request to the participant JID
-
lovetox
and prosody seems to convert it
-
lovetox
i also think we should drop the IQ one
-
Zash
Prosody MUC does the hack for vcard-temp, vcard4 (the iq) and PEP, so either works
-
lovetox
can it do the same for avatar?
-
Zash
avatar is PEP, right?
-
lovetox
yes
-
lovetox
so you are saying it does it for all pep requests
-
lovetox
not specifically for vcard ones
-
lovetox
hmm
-
lovetox
can i drop vcard-temp ..
-
lovetox
i can simlpy request pubsub with the avatar hash, if im not mistaken
-
lovetox
though with the conversion mods it doesnt matter anyway