-
Daniel
lovetox: I think we generally came to the conclusion that everything always references the original (Stanza) id, no?
-
Daniel
Like reactions and so
-
Daniel
Because just because you edit doesn't mean your reactions go away
-
Daniel
Even further edits would reference the original id
-
Daniel
I just read LMC business rules again. I think that's clear(ish) from those rules.
-
Daniel
Whether it's clear or not it's definitely easier to define this once in LMC instead of having each XEP that references other messages state that
-
Daniel
Seems like you arrived at a similar conclusion in jdev last night
-
lovetox
No the conclusion was that display markers should not so that
-
lovetox
Also for receipts these feels weird
-
Daniel
Receipts are network level. I don't think we should factor that in (meaning just because receipts behave like that shouldn't mean display markers should too)
-
Guus
What are sensible maximum stanza sizes?
-
Guus
Openfire defines 1MB as an upper bound. What do other implementation do?
-
MattJ
Guus, 1024 * 256 bytes on c2s, 1024 * 512 bytes on s2s
-
Zash
We got those from ejabberd :)
-
MattJ
Yeah
-
MattJ
You want some overhead between what you accept from clients, and what servers will accept from you, so you'll want your c2s limit to be under (512KB - whatever payloads you might add, such as <delay>)
-
Zash
Pubsub <items> responses is another thing worth thinking about. If a user can publish hundreds of 256kb items, you can't very well return all of them without rsm paging.
-
MattJ
and while you're there, implement https://xmpp.org/extensions/xep-0478.html :)
-
Guus
I think Openfire already does that.
-
MattJ
Then while you're there, add it to your DOAP ;)
-
Guus
oh, yeah
-
Guus
we've got it in our supported XEP list, but not in the DOAP
-
Guus
we should fire someone
-
Guus
(likely me)
-
Guus
oh, we only do the advertising bit
-
MattJ
Maybe add it with a note 'advertising only'
-
Guus
`<xmpp:status>partial</xmpp:status>` right?
-
MattJ
Yes
-
MattJ
and <xmpp:note xmln:lang='en'>Advertisement only</xmpp:note>
-
Zash
xml:lang!
-
MattJ
Oops
-
MattJ
Obvious what my fingers wanted to type
-
Zash
Oh, I didn't even notice the typo :D
-
Guus
https://github.com/igniterealtime/Openfire/pull/2453
-
Zash
suggestion: += `<xmpp:version>0.1.0</xmpp:version>`
-
Guus
ack
-
theTedd
In 0478: _"leads to problems with large stanzas causing connection outages, most often User Avatar (XEP-0084) [1] and XMPP Registrar Function (XEP-0053) [2] result stanzas"_ -- what are Registrar stanzas? 😜️ Should be XEP-0054?
-
Zash
off-by-one, at this time of year, localized entirely within this xep?
-
theTedd
The registry doesn't work because the stanzas are too large!
-
Zash
yes but also no
-
moparisthebest
Seems as good of a scapegoat as anything else